This is an archive of the discontinued LLVM Phabricator instance.

Differential D46378

Undef the macros after their use
ClosedPublic

Authored by hiraditya on May 2 2018, 11:21 PM.

Details

Reviewers
t.p.northover
Eugene.Zelenko
Commits
rG9a5e3d39f693: Undef the macros after their use
rL373176: Undef the macros after their use

Diff Detail

Event Timeline

hiraditya created this revision.May 2 2018, 11:21 PM
Eugene.Zelenko added a comment.May 3 2018, 6:09 AM

I don't see anything wrong with this change, but will be good idea to wait for code owner approval.

include/llvm/MC/MCLinkerOptimizationHint.h
80

You could return {}.

hiraditya updated this revision to Diff 145043.May 3 2018, 10:43 AM

return {}.

hiraditya marked an inline comment as done.May 3 2018, 10:43 AM
hiraditya added a comment.May 10 2018, 1:28 PM

ping

hiraditya added a comment.May 31 2018, 12:52 PM

I'll merge this patch as if there are no further feedbacks.

hiraditya updated this revision to Diff 222340.Sep 29 2019, 7:40 PM

rebase

Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2019, 7:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 29 2019, 7:45 PM
Closed by commit rL373176: Undef the macros after their use (authored by hiraditya). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
MC/
2 lines

Diff 144983

include/llvm/MC/MCLinkerOptimizationHint.h

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines return StringSwitch<int>(Name)
MCLOHCaseNameToId(AdrpLdr) MCLOHCaseNameToId(AdrpLdr)
MCLOHCaseNameToId(AdrpAddLdr) MCLOHCaseNameToId(AdrpAddLdr)
MCLOHCaseNameToId(AdrpLdrGotLdr) MCLOHCaseNameToId(AdrpLdrGotLdr)
MCLOHCaseNameToId(AdrpAddStr) MCLOHCaseNameToId(AdrpAddStr)
MCLOHCaseNameToId(AdrpLdrGotStr) MCLOHCaseNameToId(AdrpLdrGotStr)
MCLOHCaseNameToId(AdrpAdd) MCLOHCaseNameToId(AdrpAdd)
MCLOHCaseNameToId(AdrpLdrGot) MCLOHCaseNameToId(AdrpLdrGot)
.Default(-1); .Default(-1);
#undef MCLOHCaseNameToId
} }
static inline StringRef MCLOHIdToName(MCLOHType Kind) { static inline StringRef MCLOHIdToName(MCLOHType Kind) {
#define MCLOHCaseIdToName(Name) case MCLOH_ ## Name: return StringRef(#Name); #define MCLOHCaseIdToName(Name) case MCLOH_ ## Name: return StringRef(#Name);
switch (Kind) { switch (Kind) {
MCLOHCaseIdToName(AdrpAdrp); MCLOHCaseIdToName(AdrpAdrp);
MCLOHCaseIdToName(AdrpLdr); MCLOHCaseIdToName(AdrpLdr);
MCLOHCaseIdToName(AdrpAddLdr); MCLOHCaseIdToName(AdrpAddLdr);
MCLOHCaseIdToName(AdrpLdrGotLdr); MCLOHCaseIdToName(AdrpLdrGotLdr);
MCLOHCaseIdToName(AdrpAddStr); MCLOHCaseIdToName(AdrpAddStr);
MCLOHCaseIdToName(AdrpLdrGotStr); MCLOHCaseIdToName(AdrpLdrGotStr);
MCLOHCaseIdToName(AdrpAdd); MCLOHCaseIdToName(AdrpAdd);
MCLOHCaseIdToName(AdrpLdrGot); MCLOHCaseIdToName(AdrpLdrGot);
} }
return StringRef(); return StringRef();
Eugene.ZelenkoUnsubmitted
Done
ReplyInline Actions

You could return {}.

Eugene.Zelenko: You could return {}.
#undef MCLOHCaseIdToName
} }
static inline int MCLOHIdToNbArgs(MCLOHType Kind) { static inline int MCLOHIdToNbArgs(MCLOHType Kind) {
switch (Kind) { switch (Kind) {
// LOH with two arguments // LOH with two arguments
case MCLOH_AdrpAdrp: case MCLOH_AdrpAdrp:
case MCLOH_AdrpLdr: case MCLOH_AdrpLdr:
case MCLOH_AdrpAdd: case MCLOH_AdrpAdd:
▲ Show 20 Lines • Show All 100 Lines • Show Last 20 Lines