This is an archive of the discontinued LLVM Phabricator instance.

Update ThinLTO test
AcceptedPublic

Authored by rdhindsa on May 2 2018, 5:22 PM.

Details

Summary

Updated thinLTO test to not include forward or backward slash for testing. (It was erroring out on windows)
Added code to not generate empty index files only if thinlto-index-only option is turned on.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

rdhindsa created this revision.May 2 2018, 5:22 PM
rdhindsa added a reviewer: pcc.May 2 2018, 5:23 PM
pcc accepted this revision.May 2 2018, 5:25 PM

LGTM

This revision is now accepted and ready to land.May 2 2018, 5:25 PM
grimar added a subscriber: grimar.May 3 2018, 3:55 AM
grimar added inline comments.
lld/ELF/LTO.cpp
199

This needs a test case.

Actually, this part should have been in a different patch from "Updated thinLTO test to not include forward or backward slash for testing." part.

grimar added inline comments.May 3 2018, 3:59 AM
lld/ELF/LTO.cpp
199

.. because fixing windows BB failures (I guess) is different from changing the functionality.

pcc added inline comments.May 3 2018, 11:46 AM
lld/ELF/LTO.cpp
199

Yes, this should have included a test. @rdhindsa can you please add one?