[MCA] [NFC] Remove unused Index formal from ResourceManager::issueInstruction

[mattd]

Summary

The instruction index was never referenced in the body. Just a minor cleanup.

[mattd]

As a side note, who do we contact to get MCA or LLVM-MCA as a recognized phabricator tag? I'd like to have mca patches hit my inbox differently, and Phabricator tags definitely help me there :)

[andreadb]

Lgtm.

[probinson]

In D46142#1080027, @mattd wrote:

As a side note, who do we contact to get MCA or LLVM-MCA as a recognized phabricator tag? I'd like to have mca patches hit my inbox differently, and Phabricator tags definitely help me there :)

I suggest that @andreadb send a note to the llvm-admin list. Or you can, and CC him.

tools/llvm-mca/Scheduler.h

public:
 
   // Returns true if all resources are in-order, and there is at least one
   // resource which is a dispatch hazard (BufferSize = 0).
   bool mustIssueImmediately(const InstrDesc &Desc);
 
   bool canBeIssued(const InstrDesc &Desc) const;
 
   void issueInstruction(
-      unsigned Index, const InstrDesc &Desc,
+      const InstrDesc &Desc,
       llvm::SmallVectorImpl<std::pair<ResourceRef, double>> &Pipes);
 
   void cycleEvent(llvm::SmallVectorImpl<ResourceRef> &ResourcesFreed);
 
 #ifndef NDEBUG
   void dump() const {
     for (const std::pair<uint64_t, UniqueResourceState> &Resource : Resources)
       Resource.second->dump();

tools/llvm-mca/Scheduler.cpp

bool ResourceManager::mustIssueImmediately(const InstrDesc &Desc) {
 
   return std::any_of(Desc.Buffers.begin(), Desc.Buffers.end(),
                      [&](const unsigned BufferMask) {
                        return Resources[BufferMask]->isADispatchHazard();
                      });
 }
 
 void ResourceManager::issueInstruction(
-    unsigned Index, const InstrDesc &Desc,
+    const InstrDesc &Desc,
     SmallVectorImpl<std::pair<ResourceRef, double>> &Pipes) {
   for (const std::pair<uint64_t, ResourceUsage> &R : Desc.Resources) {
     const CycleSegment &CS = R.second.CS;
     if (!CS.size()) {
       releaseResource(R.first);
       continue;
     }
 

 
 void Scheduler::issueInstructionImpl(
     unsigned InstrIndex, Instruction &IS,
     SmallVectorImpl<std::pair<ResourceRef, double>> &UsedResources) {
   const InstrDesc &D = IS.getDesc();
 
   // Issue the instruction and collect all the consumed resources
   // into a vector. That vector is then used to notify the listener.
-  Resources->issueInstruction(InstrIndex, D, UsedResources);
+  Resources->issueInstruction(D, UsedResources);
 
   // Notify the instruction that it started executing.
   // This updates the internal state of each write.
   IS.execute();
 
   if (IS.isExecuting())
     IssuedQueue[InstrIndex] = &IS;
 }