This is an archive of the discontinued LLVM Phabricator instance.

Add a header file for enum IIT_Info, NFC
AbandonedPublic

Authored by GBuella on Apr 26 2018, 6:48 AM.

Details

Diff Detail

Event Timeline

GBuella created this revision.Apr 26 2018, 6:48 AM
GBuella retitled this revision from Add a header file for enum IIT_Info to Add a header file for enum IIT_Info, NFC.Apr 26 2018, 7:18 AM

TableGen cannot import a file from the IR directory. It will be considered a layering violation even though its only a header dependency.

TableGen cannot import a file from the IR directory. It will be considered a layering violation even though its only a header dependency.

OK, so where else could such a header go?

The only place you could put it is in include/llvm/Support. I suspect this is why the content was duplicated like this.

The only place you could put it is in include/llvm/Support. I suspect this is why the content was duplicated like this.

Yep! Thanks for the catch, Craig!

GBuella added a comment.EditedApr 26 2018, 1:07 PM

Well, putting it under include/llvm/Support just sounds weird.
Nevermind, we can survive this enum. Just need to fix the comment referencing the lib/VMCore/Function.cpp file.

It wouldn't be the only weird file in support. See MachineValueType.h, and X86DisassemblerDecodercommon.h as recent examples.

If you want to just fix the comment to say IR instead of VMCore, feel free to do that without a review.

tra removed a reviewer: tra.May 1 2018, 1:58 PM
GBuella abandoned this revision.May 8 2018, 4:04 AM