Details
Details
- Reviewers
craig.topper dblaikie
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 17447 Build 17447: arc lint + arc unit
Event Timeline
Comment Actions
TableGen cannot import a file from the IR directory. It will be considered a layering violation even though its only a header dependency.
Comment Actions
The only place you could put it is in include/llvm/Support. I suspect this is why the content was duplicated like this.
Comment Actions
Well, putting it under include/llvm/Support just sounds weird.
Nevermind, we can survive this enum. Just need to fix the comment referencing the lib/VMCore/Function.cpp file.
Comment Actions
It wouldn't be the only weird file in support. See MachineValueType.h, and X86DisassemblerDecodercommon.h as recent examples.
If you want to just fix the comment to say IR instead of VMCore, feel free to do that without a review.