This is an archive of the discontinued LLVM Phabricator instance.

Rename sancov.cc to sancov.cpp
ClosedPublic

Authored by thakis on Apr 25 2018, 10:13 AM.

Details

Reviewers
rnk
Summary

LLVM uses cpp as its C++ file ending.

Diff Detail

Event Timeline

thakis created this revision.Apr 25 2018, 10:13 AM
rnk accepted this revision.Apr 25 2018, 10:29 AM
rnk added a subscriber: dberris.

lgtm

The sanitizer parts of compiler-rt use .cc, which is probably why this uses .cc. At least the sanitizer files are self-consistent and don't mix with most of LLVM.

BTW, llvm-xray uses .cc as well. (@dberris)

This revision is now accepted and ready to land.Apr 25 2018, 10:29 AM
thakis closed this revision.Apr 25 2018, 11:09 AM

r330853, thanks!

In D46068#1078372, @rnk wrote:

lgtm

The sanitizer parts of compiler-rt use .cc, which is probably why this uses .cc. At least the sanitizer files are self-consistent and don't mix with most of LLVM.

BTW, llvm-xray uses .cc as well. (@dberris)

Whoops. Yes, we should change that as well.