Page MenuHomePhabricator

Bring r329960 back
ClosedPublic

Authored by espindola on Apr 24 2018, 4:57 PM.

Details

Reviewers
rnk
ruiu
pcc
Summary

Now that I have debugged this further, I don't think this is the best solution.

But there is an easy fix to the old patch (setting Used) and it is probably better to first commit this and then review the alternative.

Diff Detail

Event Timeline

espindola created this revision.Apr 24 2018, 4:57 PM

Actually, I misread the location of the call to demoteSharedSymbols. I now think this is the proper fix as it just simplifies the symbols before we start processing the relocations.

ruiu accepted this revision.Apr 24 2018, 5:14 PM

LGTM

ELF/Driver.cpp
1127

Please add {} here and one line below.

This revision is now accepted and ready to land.Apr 24 2018, 5:14 PM