This is an archive of the discontinued LLVM Phabricator instance.

Differential D46017

Add test cases to prepare for the optimization that simplifies Add with remainder expressions as operands.
ClosedPublic

Authored by bixia on Apr 24 2018, 8:42 AM.

Details

Reviewers
sanjoy
Commits
rG0e643db48ff9: Add test cases to prepare for the optimization that simplifies Add with…
rL330991: Add test cases to prepare for the optimization that simplifies Add with
Summary

Add test cases to prepare for the new optimization that Simplifies
integer add expression X % C0 + (( X / C0 ) % C1) * C0 to X % (C0 * C1).

Diff Detail

Event Timeline

bixia created this revision.Apr 24 2018, 8:42 AM
Herald added subscribers: llvm-commits, jlebar. · View Herald TranscriptApr 24 2018, 8:42 AM
Harbormaster completed remote builds in B17371: Diff 143755.Apr 24 2018, 8:44 AM
bixia updated this revision to Diff 143762.Apr 24 2018, 9:10 AM
  • Use instnamer to fix the name of the tests.

Updating D46017: Add test cases to prepare for the optimization that simplifies Add with

remainder expressions as operands.

Harbormaster completed remote builds in B17373: Diff 143762.Apr 24 2018, 9:11 AM
bixia added a child revision: D45976: [InstCombine] Simplify Add with remainder expressions as operands..Apr 24 2018, 9:43 AM
sanjoy accepted this revision.Apr 24 2018, 11:24 AM

lgtm modulo the one nit

Let me know if I should commit this for you.

test/Transforms/InstCombine/add4.ll
3

You can probably remove these two lines.

This revision is now accepted and ready to land.Apr 24 2018, 11:24 AM
Closed by commit rL330991: Add test cases to prepare for the optimization that simplifies Add with (authored by sanjoy). · Explain WhyApr 26 2018, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Transforms/
InstCombine/
73 lines

Diff 143755

test/Transforms/InstCombine/add4.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instcombine -S | FileCheck %s
; Test transformation: X % C0 + (( X / C0 ) % C1) * C0 => X % (C0 * C1)
sanjoyUnsubmitted
Not Done
ReplyInline Actions

You can probably remove these two lines.

sanjoy: You can probably remove these two lines.
define i64 @match_unsigned(i64 %x) {
; CHECK-LABEL: @match_unsigned(
; CHECK: [[TMP:%.*]] = add
; CHECK-NEXT: ret i64 [[TMP]]
;
%1 = urem i64 %x, 299
%2 = udiv i64 %x, 299
%3 = urem i64 %2, 64
%4 = mul i64 %3, 299
%5 = add nuw nsw i64 %1, %4
ret i64 %5
}
define i64 @match_andAsRem_lshrAsDiv_shlAsMul(i64 %x) {
; CHECK-LABEL: @match_andAsRem_lshrAsDiv_shlAsMul(
; CHECK: [[TMP:%.*]] = or
; CHECK-NEXT: ret i64 [[TMP]]
;
%1 = and i64 %x, 63
%2 = lshr i64 %x, 6
%3 = urem i64 %2, 9
%4 = shl nuw nsw i64 %3, 6
%5 = add nuw nsw i64 %1, %4
ret i64 %5
}
define i64 @match_signed(i64 %x) {
; CHECK-LABEL: @match_signed(
; CHECK: [[TMP1:%.*]] = add
; CHECK: [[TMP2:%.*]] = add
; CHECK-NEXT: ret i64 [[TMP2]]
;
%1 = srem i64 %x, 299
%2 = sdiv i64 %x, 299
%3 = srem i64 %2, 64
%4 = sdiv i64 %x, 19136
%5 = srem i64 %4, 9
%6 = mul nuw nsw i64 %3, 299
%7 = add nuw nsw i64 %1, %6
%8 = mul nuw nsw i64 %5, 19136
%9 = add nuw nsw i64 %7, %8
ret i64 %9
}
define i64 @not_match_inconsistent_signs(i64 %x) {
; CHECK-LABEL: @not_match_inconsistent_signs(
; CHECK: [[TMP:%.*]] = add
; CHECK-NEXT: ret i64 [[TMP]]
;
%1 = urem i64 %x, 299
%2 = sdiv i64 %x, 299
%3 = urem i64 %2, 64
%4 = mul i64 %3, 299
%5 = add nuw nsw i64 %1, %4
ret i64 %5
}
define i64 @not_match_inconsistent_values(i64 %x) {
; CHECK-LABEL: @not_match_inconsistent_values(
; CHECK: [[TMP:%.*]] = add
; CHECK-NEXT: ret i64 [[TMP]]
;
%1 = urem i64 %x, 299
%2 = udiv i64 %x, 29
%3 = urem i64 %2, 64
%4 = mul i64 %3, 299
%5 = add nuw nsw i64 %1, %4
ret i64 %5
}