[DebugInfo] Use WithColor for more debug line warnings

[andrewng]

Summary

Updated two more debug line related warnings to use WithColor. This was
necessary to ensure consistent output order of the warnings on Windows
for debug line tests.

[JDevlieghere]

Great, thank you! LGTM

llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugLine.cpp

if (Opcode == 0) {
         // that affect the address register add a delta to it. This instruction
         // stores a relocatable value into it instead.
         //
         // Make sure the extractor knows the address size.  If not, infer it
         // from the size of the operand.
         if (DebugLineData.getAddressSize() == 0)
           DebugLineData.setAddressSize(Len - 1);
         else if (DebugLineData.getAddressSize() != Len - 1) {
-          fprintf(stderr, "Mismatching address size at offset 0x%8.8" PRIx32
+          WithColor::warning()
+              << format("mismatching address size at offset 0x%8.8" PRIx32
                         " expected 0x%2.2" PRIx8 " found 0x%2.2" PRIx64 "\n",
                         ExtOffset, DebugLineData.getAddressSize(), Len - 1);
           // Skip the rest of the line-number program.
           *OffsetPtr = EndOffset;
           return false;
         }
         State.Row.Address = DebugLineData.getRelocatedAddress(OffsetPtr);
         if (OS)
           *OS << format(" (0x%16.16" PRIx64 ")", State.Row.Address);
         break;
if (Opcode == 0) {
         // Len doesn't include the zero opcode byte or the length itself, but
         // it does include the sub_opcode, so we have to adjust for that.
         (*OffsetPtr) += Len - 1;
         break;
       }
       // Make sure the stated and parsed lengths are the same.
       // Otherwise we have an unparseable line-number program.
       if (*OffsetPtr - ExtOffset != Len) {
-        fprintf(stderr, "Unexpected line op length at offset 0x%8.8" PRIx32
+        WithColor::warning()
+            << format("unexpected line op length at offset 0x%8.8" PRIx32
                       " expected 0x%2.2" PRIx64 " found 0x%2.2" PRIx32 "\n",
                       ExtOffset, Len, *OffsetPtr - ExtOffset);
         // Skip the rest of the line-number program.
         *OffsetPtr = EndOffset;
         return false;
       }
     } else if (Opcode < Prologue.OpcodeBase) {
       if (OS)
         *OS << LNStandardString(Opcode);
       switch (Opcode) {

llvm/trunk/test/DebugInfo/X86/dwarfdump-bogus-LNE.s

LT2_header_end:
         .byte   2               # DW_LNE_set_address
         .quad   .text
         # Real opcode with incorrect length.
         .byte   0
         .byte   2               # Wrong length, should be 1.
         .byte   1               # DW_LNE_end_sequence
 LT2_end:
 
-# ERR:      Unexpected line op length at offset 0x0000005e
+# ERR:      warning: unexpected line op length at offset 0x0000005e
 # ERR-SAME: expected 0x02 found 0x01
 
 # The above parsing errors still let us move to the next unit.
 # If the prologue is bogus, we need to bail out because we can't
 # even find the next unit.
 
 # DWARF v4 line-table header #3.
 LT3_start:

llvm/trunk/test/DebugInfo/X86/dwarfdump-line-mismatch.s

 # The .debug_info section says 8-byte addresses, but the assembler
 # will generate a line table with 4-byte addresses (for i686).
 
 # RUN: llvm-mc -filetype=obj -triple i686-linux-gnu %s -o - | \
 # RUN: llvm-dwarfdump -debug-line - 2>&1 | FileCheck %s
 
-# CHECK: Mismatching address size at offset 0x{{[0-9a-f]+}}
+# CHECK:      warning: mismatching address size at offset 0x{{[0-9a-f]+}}
 # CHECK-SAME: expected 0x08 found 0x04
   .text
   .file "reduced.c"
   .globl  main
 main:
   .file 1 "/tmp" "reduced.c"
   .loc  1 2 0
   xorl  %eax, %eax