Page MenuHomePhabricator
Differential D45871

[DebugInfo] Use WithColor for more debug line warnings
ClosedPublic
Actions

Authored by andrewng on Apr 20 2018, 4:06 AM.

Details

Reviewers
JDevlieghere
probinson
Commits
rG7a2fa74ab046: [DebugInfo] Use WithColor for more debug line warnings
rL330440: [DebugInfo] Use WithColor for more debug line warnings
Summary

Updated two more debug line related warnings to use WithColor. This was
necessary to ensure consistent output order of the warnings on Windows
for debug line tests.

Diff Detail

Repository
rL LLVM

Event Timeline

andrewng created this revision.Apr 20 2018, 4:06 AM
JDevlieghere accepted this revision.Apr 20 2018, 5:35 AM

Great, thank you! LGTM

This revision is now accepted and ready to land.Apr 20 2018, 5:35 AM
Closed by commit rL330440: [DebugInfo] Use WithColor for more debug line warnings (authored by anng, committed by ). · Explain WhyApr 20 2018, 8:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 143322

View Options

llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugLine.cpp

Loading...
View Options

llvm/trunk/test/DebugInfo/X86/dwarfdump-bogus-LNE.s

Loading...
View Options

llvm/trunk/test/DebugInfo/X86/dwarfdump-line-mismatch.s

Loading...