Page MenuHomePhabricator

[X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153
ClosedPublic

Authored by lsaba on Apr 19 2018, 9:06 AM.

Details

Summary

Reset the Kill flag to false for the newly created small load/store instructions, except for the last created load/store which should have the original kill flag status.

Diff Detail

Event Timeline

lsaba created this revision.Apr 19 2018, 9:06 AM
craig.topper added inline comments.Apr 23 2018, 9:56 AM
lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp
421

Use X86::AddrNumOperands instead of 5?

lsaba updated this revision to Diff 143686.Apr 24 2018, 1:23 AM
lsaba marked an inline comment as done.

fix @craig.topper comment

I thought I wrote this comment when I reviewed yesterday, but I guess it didnt' get saved somehow.

lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp
398–410

Can you do

MachineInstr *NewLoad = BuildMI....

Then you don't need to use getPrevNode. same with the store below.

lsaba updated this revision to Diff 143898.Apr 25 2018, 4:06 AM
lsaba marked an inline comment as done.
This revision is now accepted and ready to land.Apr 25 2018, 9:36 AM
This revision was automatically updated to reflect the committed changes.