Page MenuHomePhabricator

lsaba (Lama)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2016, 5:39 AM (215 w, 4 d)

Recent Activity

Apr 14 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

I will commit for you.

Apr 14 2020, 12:29 AM · Restricted Project

Apr 12 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

ping

Apr 12 2020, 11:25 PM · Restricted Project

Apr 4 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

I've tested this patch with our version of LLVM and it passes our tests. I'm ok with adding the patch as-is, as long as no one else would object.

Apr 4 2020, 11:26 PM · Restricted Project

Apr 1 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

Unfortunately, I've had no luck producing a test case that generates this type of graph.

Apr 1 2020, 1:03 AM · Restricted Project

Mar 25 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

ping

Mar 25 2020, 1:03 AM · Restricted Project

Mar 24 2020

lsaba added a comment to D75424: [MachinePipeliner] Fix a bug in Output Dependency chains.

I will commit it for you.

Mar 24 2020, 8:02 AM · Restricted Project
lsaba added a comment to D75424: [MachinePipeliner] Fix a bug in Output Dependency chains.

I can't seem to get commit access to GitHub (already emailed llvm-admin twice)
Would anyone be kind enough to commit the change on behalf of me? Thanks!

Mar 24 2020, 7:29 AM · Restricted Project

Mar 12 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

Yep, stores to physical registers will create output dependences, which can be done using inline assembly. At least, most of the code in the pipeliner that deals with output dependences is exercised using inline asm code.

The only Hexagon instructions with two outputs that the compiler generates are the post-increment load instructions, and it would be difficult to create a chain of these. There are some esoteric instructions, but they are typically generated through intrinsics only. I can try to create a test for this...

Mar 12 2020, 12:52 AM · Restricted Project

Mar 11 2020

lsaba added a comment to D75918: [MachinePipeliner] Refine the RecMII calculation.

Hi @lsaba - this fix looks good to me. Thanks! It will be challenging to create a test case on Hexagon due to the output dependences. How to do get so many output dependences on your target?

re
Thanks for the fast reply!
we have an implicit physical register that certain instructions define, thus having several instructions in the code would create these output chains, the most similar to this that I found in Hexagon was the usr_ovf register, but I also saw that the Output Deps for these registers get removed in HexagonSubtarget::UsrOverflowMutation::apply.

Mar 11 2020, 1:35 AM · Restricted Project

Mar 10 2020

lsaba created D75918: [MachinePipeliner] Refine the RecMII calculation.
Mar 10 2020, 6:24 AM · Restricted Project

Mar 1 2020

lsaba created D75424: [MachinePipeliner] Fix a bug in Output Dependency chains.
Mar 1 2020, 7:26 AM · Restricted Project

Jan 15 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

I *think* I fixed it for good in in r351077.

Jan 15 2019, 12:57 AM

Jan 13 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

You have to use clang in order to compile with clang module support enabled. If your host compiler is GCC, you will have to build clang first and then use that clang to compile clang again using all the MODULE cmake options.

Jan 13 2019, 7:15 AM

Jan 9 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

You have to use clang in order to compile with clang module support enabled. If your host compiler is GCC, you will have to build clang first and then use that clang to compile clang again using all the MODULE cmake options.

Jan 9 2019, 9:08 AM
lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

Hmmm.. my fix didn't go far enough. I reverted this patch once again, so we can sort this out without pressure. As long as you make sure that compiling with -DLLVM_ENABLE_MODULES=1 works, feel free to recommit at any

Jan 9 2019, 6:49 AM

Jan 8 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

I committed a rather horrible workaround in r350650, but it would be great to revert that again.

What you need to test particularly is building with -DLLVM_ENABLE_MODULES=1.

Jan 8 2019, 2:35 PM
lsaba added a reverting change for rL350497: Revert "Resubmit rL345008 "Split MachinePipeliner code into header and cpp…: rL350621: Revert "Revert "Resubmit rL345008 "Split MachinePipeliner code into header and….
Jan 8 2019, 5:34 AM
lsaba committed rL350621: Revert "Revert "Resubmit rL345008 "Split MachinePipeliner code into header and….
Revert "Revert "Resubmit rL345008 "Split MachinePipeliner code into header and…
Jan 8 2019, 5:34 AM
lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

Looks like these are unrelated failures. TestQueues started acting up last week because of a concurrency issue. I would recommend you attempt to re-land your commit again and see if any new failures show up. If you are unsure, feel free to ask here or on #llvm on IRC.

Jan 8 2019, 2:07 AM

Jan 7 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

@aprantl Found a workaround for the lldb-cmake bot: https://reviews.llvm.org/rL350346

I tested it locally with your patch reapplied and the error is fixed. Sorry again for the hassle. Please submit your patch. Thanks

@aprantl , @sgraenitz , I tried to resbumit the patch in https://reviews.llvm.org/rL350493 but unfortunately issues with the modules still appear: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/314/steps/test/logs/stdio

it is now able to build but the lit test SymbolFile/PDB/class-layout.test is failing:

$ ":" "RUN: at line 4"
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb-test.EXE" "symbols" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\PDB\Output/ClassLayoutTest.cpp.exe"

command stderr:

error: Module has no symbol vendor.

error: command failed with exit status: 1
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\PDB\class-layout.test"

command stderr:

E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\PDB\class-layout.test:15:8: error: CHECK: expected string not found in input
CHECK: Module [[MOD:.*]]

^

<stdin>:1:1: note: scanning from here
Module: E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\PDB\Output/ClassLayoutTest.cpp.exe

I have reverted the patch again for now as I am unable to reproduce the issue locally, your help will be much apprecicated

Even though this error also has Module in the name, this is a completely unrelated issue. Unfortunately Module is a terribly overloaded term. Are you sure that this was actually caused by your commit? It sounds unlikely.

Jan 7 2019, 11:19 AM

Jan 6 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

@aprantl Found a workaround for the lldb-cmake bot: https://reviews.llvm.org/rL350346

I tested it locally with your patch reapplied and the error is fixed. Sorry again for the hassle. Please submit your patch. Thanks

Jan 6 2019, 8:50 AM
lsaba committed rL350497: Revert "Resubmit rL345008 "Split MachinePipeliner code into header and cpp….
Revert "Resubmit rL345008 "Split MachinePipeliner code into header and cpp…
Jan 6 2019, 8:45 AM
lsaba added a reverting change for rL350493: Resubmit rL345008 "Split MachinePipeliner code into header and cpp files": rL350497: Revert "Resubmit rL345008 "Split MachinePipeliner code into header and cpp….
Jan 6 2019, 8:45 AM
lsaba committed rL350493: Resubmit rL345008 "Split MachinePipeliner code into header and cpp files".
Resubmit rL345008 "Split MachinePipeliner code into header and cpp files"
Jan 6 2019, 7:50 AM

Jan 4 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

@aprantl Found a workaround for the lldb-cmake bot: https://reviews.llvm.org/rL350346

I tested it locally with your patch reapplied and the error is fixed. Sorry again for the hassle. Please submit your patch. Thanks

Jan 4 2019, 2:39 AM

Jan 3 2019

lsaba added a comment to rL350290: Resubmit rL345008 "Split MachinePipeliner code into header and cpp files".

Looks like the patch has just been reverted in rL350345. Please let me know if you have problems reproducing the failure.

Jan 3 2019, 11:53 AM
lsaba committed rL350296: [MachinePipeliner] Add missing header file to MachinePipeliner.h.
[MachinePipeliner] Add missing header file to MachinePipeliner.h
Jan 3 2019, 4:00 AM
lsaba committed rL350290: Resubmit rL345008 "Split MachinePipeliner code into header and cpp files".
Resubmit rL345008 "Split MachinePipeliner code into header and cpp files"
Jan 3 2019, 2:07 AM
lsaba closed D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".
Jan 3 2019, 2:07 AM

Jan 2 2019

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

Ping2
@craig.topper is this okay with you?

Jan 2 2019, 7:22 AM
lsaba added a reviewer for D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files": qcolombet.
Jan 2 2019, 5:02 AM

Dec 30 2018

lsaba added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

Ping

Dec 30 2018, 1:04 AM

Dec 26 2018

lsaba added a reviewer for D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files": craig.topper.
Dec 26 2018, 8:29 AM
lsaba created D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".
Dec 26 2018, 5:40 AM

Dec 18 2018

lsaba added a comment to D55642: [X86] Fix assert fails in pass X86AvoidSFBPass.

LGTM, with a small nit.

In general, I'm not sure whether the overall behavior here makes sense. Especially in the case where the blocking stores don't come from different BBs, it would make more sense to me to preserve the last (in program order) of the overlapping stores, rather than the smallest, as that's the store that will be forwarded. If the stores come from multiple predecessors (like here) it's less clear which choice is right.

But in any case, that would require larger changes and shouldn't block this assertion fix.

Dec 18 2018, 7:09 AM

Dec 13 2018

lsaba added a comment to D55642: [X86] Fix assert fails in pass X86AvoidSFBPass.

no comments from my side (LGTM)

Dec 13 2018, 9:59 AM

Dec 10 2018

lsaba accepted D55485: [X86] Fix avoid store forwarding blocks pass for negative displacements.
Dec 10 2018, 12:47 AM

Oct 23 2018

lsaba committed rL345008: [MachinePipeliner] Split MachinePipeliner code into header and cpp files.
[MachinePipeliner] Split MachinePipeliner code into header and cpp files
Oct 23 2018, 1:00 AM
lsaba closed D53477: Split MachinePipeliner code into header and cpp files.
Oct 23 2018, 1:00 AM

Oct 21 2018

lsaba created D53477: Split MachinePipeliner code into header and cpp files.
Oct 21 2018, 2:50 AM

May 21 2018

lsaba committed rL332849: [X86] - Avoid SFB pass - fix bug in updating the offsets for newly created….
[X86] - Avoid SFB pass - fix bug in updating the offsets for newly created…
May 21 2018, 9:27 AM

Apr 26 2018

lsaba committed rL330939: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.
[X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153
Apr 26 2018, 6:19 AM
lsaba closed D45823: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.
Apr 26 2018, 6:19 AM

Apr 25 2018

lsaba updated the diff for D45823: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.

done @craig.topper

Apr 25 2018, 4:08 AM

Apr 24 2018

lsaba updated the diff for D45823: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.

fix @craig.topper comment

Apr 24 2018, 1:26 AM

Apr 22 2018

lsaba added a comment to D45823: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.

ping

Apr 22 2018, 3:39 AM

Apr 19 2018

lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

This seems to break the Machine Verifier. I filed PR37153. Do you mind taking a look please? Thanks!

Apr 19 2018, 9:07 AM
lsaba created D45823: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.
Apr 19 2018, 9:06 AM

Apr 18 2018

lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

This seems to break the Machine Verifier. I filed PR37153. Do you mind taking a look please? Thanks!

Apr 18 2018, 12:57 AM

Apr 6 2018

lsaba abandoned D43619: [X86] Limit Store Forwarding Block only to cases where we can prove that the memcpy does not overlap.

@zvi the changes in this commit were added to https://reviews.llvm.org/D41330 and committed already. I will close this patch

Apr 6 2018, 1:31 AM

Apr 2 2018

lsaba committed rL328973: [X86] Reduce Store Forward Block issues in HW - Recommit after fixing Bug 36346.
[X86] Reduce Store Forward Block issues in HW - Recommit after fixing Bug 36346
Apr 2 2018, 6:53 AM
lsaba closed D41330: [X86] Reduce Store Forward Block issues in HW.
Apr 2 2018, 6:53 AM

Mar 30 2018

lsaba added inline comments to D41330: [X86] Reduce Store Forward Block issues in HW.
Mar 30 2018, 12:30 AM

Mar 29 2018

lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

Updated with @craig.topper comments

Mar 29 2018, 7:11 AM
lsaba added inline comments to D41330: [X86] Reduce Store Forward Block issues in HW.
Mar 29 2018, 7:10 AM

Mar 27 2018

lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

The changes from just D43619 look correct but I haven't looked deeply at this part of the patch. From the comments it looks like the patch is a bit out of date as std::map should have been converted back to switch statements.

Mar 27 2018, 11:55 PM
lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

ping @ reviewers, if there are no more comments i'd like to re-submit this

Mar 27 2018, 4:18 AM

Mar 22 2018

lsaba added a comment to D43619: [X86] Limit Store Forwarding Block only to cases where we can prove that the memcpy does not overlap.

Fixed comments in review https://reviews.llvm.org/D41330

Mar 22 2018, 6:44 AM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

fix comments from @niravd and @craig.topper in review https://reviews.llvm.org/D43619#inline-381377 (closing that one)

Mar 22 2018, 6:43 AM

Mar 19 2018

lsaba reopened D41330: [X86] Reduce Store Forward Block issues in HW.
Mar 19 2018, 8:30 AM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

Fix the reported bug (added case to bug 36346, based on code provided by Richard Smith )
and limit the transformation to 64bit only

Mar 19 2018, 8:23 AM

Feb 22 2018

lsaba added a comment to D43619: [X86] Limit Store Forwarding Block only to cases where we can prove that the memcpy does not overlap.

@chandlerc there's a good chance this solves the miscompilations you are seeing

Feb 22 2018, 6:51 AM
lsaba created D43619: [X86] Limit Store Forwarding Block only to cases where we can prove that the memcpy does not overlap.
Feb 22 2018, 6:51 AM

Feb 20 2018

lsaba added inline comments to D41330: [X86] Reduce Store Forward Block issues in HW.
Feb 20 2018, 9:23 AM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

@chandlerc Thanks for your comments.
still checking the option of using tablegen for some of the tables.
Any luck with the reproducer?

Feb 20 2018, 9:23 AM

Feb 14 2018

lsaba committed rL325128: [X86] Reduce Store Forward Block issues in HW - Recommit after fixing Bug 36346.
[X86] Reduce Store Forward Block issues in HW - Recommit after fixing Bug 36346
Feb 14 2018, 7:03 AM

Feb 11 2018

lsaba committed rL324836: fix test/CodeGen/X86/fixup-sfb.ll test failure after commit https://reviews..
fix test/CodeGen/X86/fixup-sfb.ll test failure after commit https://reviews.
Feb 11 2018, 2:35 AM
lsaba closed D41330: [X86] Reduce Store Forward Block issues in HW.

committed in https://reviews.llvm.org/rL324835

Feb 11 2018, 1:38 AM
lsaba committed rL324835: [X86] Reduce Store Forward Block issues in HW.
[X86] Reduce Store Forward Block issues in HW
Feb 11 2018, 1:36 AM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

fixed TRI @craig.topper

Feb 11 2018, 12:26 AM

Feb 8 2018

lsaba added inline comments to D41330: [X86] Reduce Store Forward Block issues in HW.
Feb 8 2018, 12:37 PM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

addressed @craig.topper 's comments

Feb 8 2018, 12:37 PM
lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

ping to reviewers

Feb 8 2018, 12:04 AM

Feb 6 2018

lsaba added a reviewer for D41330: [X86] Reduce Store Forward Block issues in HW: oren_ben_simhon.
Feb 6 2018, 6:13 AM

Feb 4 2018

lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

addressed @craig.topper comments

Feb 4 2018, 1:31 AM

Jan 31 2018

lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.
Jan 31 2018, 9:25 AM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

addressed comments from @RKSimon and @craig.topper

Jan 31 2018, 9:21 AM

Jan 25 2018

lsaba accepted D42522: [X86] Fix killed flag handling in X86FixupLea pass.
Jan 25 2018, 1:11 AM

Jan 16 2018

lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

Pinging again,,

Jan 16 2018, 1:17 AM

Jan 8 2018

lsaba added a comment to D41330: [X86] Reduce Store Forward Block issues in HW.

Ping.

Jan 8 2018, 12:32 AM

Jan 3 2018

lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

addressed @hfinkel comments.
ping to reviewers.

Jan 3 2018, 12:04 AM

Dec 26 2017

lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

add MMO info

Dec 26 2017, 4:00 AM

Dec 20 2017

lsaba added inline comments to D41330: [X86] Reduce Store Forward Block issues in HW.
Dec 20 2017, 7:08 AM

Dec 19 2017

lsaba added inline comments to D41330: [X86] Reduce Store Forward Block issues in HW.
Dec 19 2017, 5:40 AM
lsaba updated the diff for D41330: [X86] Reduce Store Forward Block issues in HW.

Addressed Craig's comments

Dec 19 2017, 5:40 AM

Dec 17 2017

lsaba added a reviewer for D41330: [X86] Reduce Store Forward Block issues in HW: zansari.
Dec 17 2017, 3:26 AM
lsaba created D41330: [X86] Reduce Store Forward Block issues in HW.
Dec 17 2017, 3:25 AM

Dec 5 2017

lsaba accepted D39720: [X86][AVX512] lowering kunpack intrinsic - llvm part.
Dec 5 2017, 7:20 AM
lsaba accepted D39719: [X86][AVX512] lowering kunpack intrinsic - clang part.
Dec 5 2017, 5:17 AM

Nov 26 2017

lsaba added a comment to D35014: [X86] Improvement in CodeGen instruction selection for LEAs..

@RKSimon No more comments from my side

Nov 26 2017, 12:02 AM · Restricted Project

Nov 21 2017

lsaba accepted D39421: [InstCombine] Extracting common and-mask for shift operands of Or instruction.

LGTM after fixing the minor comments

Nov 21 2017, 3:28 AM
lsaba added inline comments to D39421: [InstCombine] Extracting common and-mask for shift operands of Or instruction.
Nov 21 2017, 3:28 AM

Nov 7 2017

lsaba accepted D38671: [X86][AVX512] lowering shuffle i/f intrinsic - llvm part.
Nov 7 2017, 8:16 AM
lsaba accepted D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part.
Nov 7 2017, 8:13 AM
lsaba added inline comments to D38671: [X86][AVX512] lowering shuffle i/f intrinsic - llvm part.
Nov 7 2017, 7:41 AM
lsaba added inline comments to D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part.
Nov 7 2017, 7:38 AM

Sep 13 2017

lsaba accepted D35014: [X86] Improvement in CodeGen instruction selection for LEAs..
Sep 13 2017, 7:13 AM · Restricted Project

Sep 6 2017

lsaba added a comment to D35014: [X86] Improvement in CodeGen instruction selection for LEAs..

3-Ops LEA are costly starting target SandyBridge , is there a limitation in the code for the targets this transformation works on? If not I think there should be.
you can check the Slow3OpsLEA feature for the full list of targets.

Sep 6 2017, 12:13 AM · Restricted Project

Sep 4 2017

lsaba added a comment to D35014: [X86] Improvement in CodeGen instruction selection for LEAs..

@lamas, @reviewers, comments have been taken care. Let me know if anything else.

Sep 4 2017, 8:19 AM · Restricted Project
lsaba added a comment to D35014: [X86] Improvement in CodeGen instruction selection for LEAs..

@lamas, @reviewers, comments have been taken care. Let me know if anything else.

Sep 4 2017, 12:24 AM · Restricted Project