This is an archive of the discontinued LLVM Phabricator instance.

Differential D45786

[OpenMP] Compilation error fix on const char*
ClosedPublic

Authored by aheejin on Apr 18 2018, 1:59 PM.

Details

Reviewers
jlpeyton
Commits
rGf78a49352866: [OpenMP] Compilation error fix on const char*
rOMP330299: [OpenMP] Compilation error fix on const char*
rL330299: [OpenMP] Compilation error fix on const char*
Summary

This line added in D45327 (rL330282) causes a compilation failure.

Diff Detail

Event Timeline

aheejin created this revision.Apr 18 2018, 1:59 PM
Herald added subscribers: openmp-commits, guansong. · View Herald TranscriptApr 18 2018, 1:59 PM
aheejin edited the summary of this revision. (Show Details)Apr 18 2018, 1:59 PM
Harbormaster completed remote builds in B17189: Diff 142995.Apr 18 2018, 2:01 PM
jlpeyton accepted this revision.Apr 18 2018, 2:59 PM

LGTM

This revision is now accepted and ready to land.Apr 18 2018, 2:59 PM
aheejin updated this revision to Diff 143012.Apr 18 2018, 3:25 PM

Fixing messed up branches

Closed by commit rL330299: [OpenMP] Compilation error fix on const char* (authored by aheejin). · Explain WhyApr 18 2018, 3:26 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 18 2018, 3:26 PM

Revision Contents

PathSize
runtime/
src/
2 lines

Diff 143012

runtime/src/kmp_gsupport.cpp

Show First 20 Lines • Show All 1,442 Lines • ▼ Show 20 Linesvoid __GOMP_taskloop(void (*func)(void *), void *data,
kmp_int32 flags = 0; kmp_int32 flags = 0;
int if_val = gomp_flags & (1u << 10); int if_val = gomp_flags & (1u << 10);
int nogroup = gomp_flags & (1u << 11); int nogroup = gomp_flags & (1u << 11);
int up = gomp_flags & (1u << 8); int up = gomp_flags & (1u << 8);
p_task_dup_t task_dup = NULL; p_task_dup_t task_dup = NULL;
kmp_tasking_flags_t *input_flags = (kmp_tasking_flags_t *)&flags; kmp_tasking_flags_t *input_flags = (kmp_tasking_flags_t *)&flags;
#ifdef KMP_DEBUG #ifdef KMP_DEBUG
{ {
const char *buff; char *buff;
buff = __kmp_str_format( buff = __kmp_str_format(
"GOMP_taskloop: T#%%d: func:%%p data:%%p copy_func:%%p " "GOMP_taskloop: T#%%d: func:%%p data:%%p copy_func:%%p "
"arg_size:%%ld arg_align:%%ld gomp_flags:0x%%x num_tasks:%%lu " "arg_size:%%ld arg_align:%%ld gomp_flags:0x%%x num_tasks:%%lu "
"priority:%%d start:%%%s end:%%%s step:%%%s\n", "priority:%%d start:%%%s end:%%%s step:%%%s\n",
traits_t<T>::spec, traits_t<T>::spec, traits_t<T>::spec); traits_t<T>::spec, traits_t<T>::spec, traits_t<T>::spec);
KA_TRACE(20, (buff, gtid, func, data, copy_func, arg_size, arg_align, KA_TRACE(20, (buff, gtid, func, data, copy_func, arg_size, arg_align,
gomp_flags, num_tasks, priority, start, end, step)); gomp_flags, num_tasks, priority, start, end, step));
__kmp_str_free(&buff); __kmp_str_free(&buff);
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines