Add FreeBSD support to the address sanitizer's deep_call_stack.cc test case

[samsonov]

Kostya, do you think we'd better relax the test a bit and use 15K on all platforms? I'd vote for that.

[emaste]

Kostya, do you think we'd better relax the test a bit and use 15K on all platforms? I'd vote for that.

I agree.

In addition, if we find defaults in FreeBSD that are at odds with all other contemporary platforms the FreeBSD team should give consideration to changing those defaults.

test/asan/TestCases/deep_call_stack.cc

34

Should we have a "middle" value for FreeBSD too?

[kcc]

maybe we can do 'ulimit -s' to ensure 8M stack on all platforms for this test?

[kutuzov.viktor.84]

Further investigation indicates that the problem is the main thread stack size and not the system stack size.

According to the discussion at:

http://freebsd.1045724.n5.nabble.com/libthr-and-main-thread-stack-size-td5935621.html

the main thread stack size is set to 4M on x86-64 and cannot be changed. For i386 it is half of that value.

What if we reduce the depth of the recursion for all platforms and add 'ulimit -s 4096' to the run lines?

[kutuzov.viktor.84]

Updated.

[samsonov]

I'm slightly concerned about portability, but it looks like we can use "ulimit -s" on Mac OS. I'll defer to Kostya to decide if we need even less deep recursion, or fine with making this test Posix-only.

[kcc]

test/asan/TestCases/deep_call_stack.cc

4

please don't modify limits for the other lines.
What you need is (ulimit -s 4096; %run %t)

[kutuzov.viktor.84]

Updated as specified.

[kcc]

LGTM, sorry for delay

Closed by commit rL217943 (authored by vkutuzov).

test/asan/TestCases/deep_call_stack.cc

 // Check that UAR mode can handle very deep recusrion.
 // export ASAN_OPTIONS=detect_stack_use_after_return=1
 // RUN: %clangxx_asan -O2 %s -o %t && \
-// RUN:   %run %t 2>&1 | FileCheck %s
+// RUN:   %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os
 // Also check that use_sigaltstack+verbosity doesn't crash.
-// RUN: env ASAN_OPTIONS=verbosity=1:use_sigaltstack=1 %run %t  | FileCheck %s
+// RUN: env ASAN_OPTIONS=verbosity=1:use_sigaltstack=1 %run %t | \
+// RUN:   FileCheck %s --check-prefix=CHECK-%os
 #include <stdio.h>
 
 __attribute__((noinline))
 void RecursiveFunc(int depth, int *ptr) {
   if ((depth % 1000) == 0)
     printf("[%05d] ptr: %p\n", depth, ptr);
   if (depth == 0)
     return;
   int local;
   RecursiveFunc(depth - 1, &local);
 }
 
 int main(int argc, char **argv) {
+// On FreeBSD the stack size is about 500MB by default and even less in
+// 32-bit mode.
+#if defined(__FreeBSD__)
+  RecursiveFunc(15000, 0);
+#else
   RecursiveFunc(40000, 0);
+#endif
   return 0;
 }
-// CHECK: [40000] ptr:
-// CHECK: [20000] ptr:
-// CHECK: [00000] ptr
+// CHECK-Linux: [40000] ptr:
+// CHECK-Linux: [20000] ptr:
+// CHECK-Linux: [00000] ptr:
+
+// CHECK-FreeBSD: [15000] ptr:
+// CHECK-FreeBSD: [00000] ptr:
+
+// CHECK-Darwin: [40000] ptr:
+// CHECK-Darwin: [20000] ptr:
+// CHECK-Darwin: [00000] ptr: