This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Remove duplicate cmake flags
ClosedPublic

Authored by cryptoad on Apr 12 2018, 9:30 AM.

Reviewers

Commits

Summary

Now that common options are propagated again for runtimes build with D45507,
the -f{data,function}-sections flags are now duplicates, remove them.

This revision is now accepted and ready to land.Apr 12 2018, 9:42 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

scudo/

2 lines

	add_compiler_rt_component(scudo)			add_compiler_rt_component(scudo)

	include_directories(..)			include_directories(..)

	set(SCUDO_CFLAGS ${SANITIZER_COMMON_CFLAGS})			set(SCUDO_CFLAGS ${SANITIZER_COMMON_CFLAGS})
	# SANITIZER_COMMON_CFLAGS include -fno-builtin, but we actually want builtins!			# SANITIZER_COMMON_CFLAGS include -fno-builtin, but we actually want builtins!
	list(APPEND SCUDO_CFLAGS -fbuiltin -ffunction-sections -fdata-sections)			list(APPEND SCUDO_CFLAGS -fbuiltin)
	append_rtti_flag(OFF SCUDO_CFLAGS)			append_rtti_flag(OFF SCUDO_CFLAGS)

	set(SCUDO_DYNAMIC_LIBS ${SANITIZER_COMMON_LINK_LIBS})			set(SCUDO_DYNAMIC_LIBS ${SANITIZER_COMMON_LINK_LIBS})
	append_list_if(COMPILER_RT_HAS_LIBDL dl SCUDO_DYNAMIC_LIBS)			append_list_if(COMPILER_RT_HAS_LIBDL dl SCUDO_DYNAMIC_LIBS)
	append_list_if(COMPILER_RT_HAS_LIBRT rt SCUDO_DYNAMIC_LIBS)			append_list_if(COMPILER_RT_HAS_LIBRT rt SCUDO_DYNAMIC_LIBS)
	append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread SCUDO_DYNAMIC_LIBS)			append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread SCUDO_DYNAMIC_LIBS)
	append_list_if(COMPILER_RT_HAS_LIBLOG log SCUDO_DYNAMIC_LIBS)			append_list_if(COMPILER_RT_HAS_LIBLOG log SCUDO_DYNAMIC_LIBS)

	▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines