This is an archive of the discontinued LLVM Phabricator instance.

[X86] Disable SGX for Skylake Server - CPP test
ClosedPublic

Authored by GBuella on Apr 10 2018, 7:46 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

GBuella created this revision.Apr 10 2018, 7:46 AM

I don't think this change is correct. To the best of my knowledge, SKL does support SGX but SKX does not.

GBuella updated this revision to Diff 141853.Apr 10 2018, 7:57 AM

I don't think this change is correct. To the best of my knowledge, SKL does support SGX but SKX does not.

llvm-lit test/Preprocessor/predefined-arch-macros.c passes now.
I didn't know tests are not run automatically precommit around here, now I know I must always check them manually... sorry

davezarzycki accepted this revision.Apr 10 2018, 8:02 AM
This revision is now accepted and ready to land.Apr 10 2018, 8:02 AM
This revision was automatically updated to reflect the committed changes.