This is an archive of the discontinued LLVM Phabricator instance.

[Power9]Legalize and emit code for converting (Un)Signed Word to Quad-Precision
ClosedPublic

Authored by lei on Apr 6 2018, 1:27 PM.

Diff Detail

Event Timeline

lei created this revision.Apr 6 2018, 1:27 PM
lei updated this revision to Diff 141835.Apr 10 2018, 6:50 AM
lei updated this revision to Diff 142225.Apr 12 2018, 11:28 AM

Add test case for X-FORM loads.

nemanjai accepted this revision.Apr 18 2018, 6:56 AM

Other than a couple of minor nits, LGTM.

test/CodeGen/PowerPC/f128-conv.ll
129

Is this supposed to be CHECK-NOT: lwz?

148

This seems weird. Where is the offset from the start of the array calculated?

This revision is now accepted and ready to land.Apr 18 2018, 6:56 AM
lei added inline comments.Apr 18 2018, 8:31 AM
test/CodeGen/PowerPC/f128-conv.ll
129

yes.

148

missing addi
Will update to:

; CHECK: addi [[REG2:[0-9]+]], [[REG]], 12
; CHECK: lxsiwax [[REG0:[0-9]+]], 0, [[REG2]]
This revision was automatically updated to reflect the committed changes.