Page MenuHomePhabricator

[LLVM-C] Move DIBuilder Bindings For Block Scopes
ClosedPublic

Authored by CodaFi on Apr 5 2018, 9:02 PM.

Details

Summary

Move LLVMDIBuilderCreateFunction , LLVMDIBuilderCreateLexicalBlock, and LLVMDIBuilderCreateLexicalBlockFile from Go to LLVM-C.

Diff Detail

Repository
rL LLVM

Event Timeline

CodaFi created this revision.Apr 5 2018, 9:02 PM

Do you think you could add a test? (Do we have tests for DIBuilder at all?)

CodaFi added a comment.Apr 5 2018, 9:09 PM

I'll need to move the Function scope API as well to write a coherent test.

Sounds like a plan.

CodaFi updated this revision to Diff 141398.Apr 6 2018, 12:02 PM
CodaFi edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 6 2018, 12:23 PM
harlanhaskins requested changes to this revision.Apr 6 2018, 4:01 PM

LGTM after that one small go style change.

bindings/go/llvm/dibuilder.go
210 ↗(On Diff #141398)

Can you put these on the next line?

This revision now requires changes to proceed.Apr 6 2018, 4:01 PM
CodaFi added inline comments.Apr 6 2018, 6:58 PM
bindings/go/llvm/dibuilder.go
210 ↗(On Diff #141398)

This matches the formatting in the rest of the file.

harlanhaskins accepted this revision.Apr 6 2018, 8:03 PM
This revision is now accepted and ready to land.Apr 6 2018, 8:03 PM
This revision was automatically updated to reflect the committed changes.