Page MenuHomePhabricator

[LoopUnroll] Make LoopPeeling respect the AllowPeeling preference.
ClosedPublic

Authored by mcrosier on Apr 5 2018, 1:52 PM.

Details

Summary

AFAICT, the SimpleLoopUnrollPass isn't suppose to perform loop peeling.

Chad

Diff Detail

Repository
rL LLVM

Event Timeline

mcrosier created this revision.Apr 5 2018, 1:52 PM
efriedma accepted this revision.Apr 5 2018, 2:45 PM

LGTM

It's possible that peeling which "simplifies" a loop should be done earlier, but completely ignoring AllowPeeling seems wrong.

This revision is now accepted and ready to land.Apr 5 2018, 2:45 PM
fhahn accepted this revision.Apr 5 2018, 3:00 PM

Thanks Chad, AllowPeeling and UserPeelCount taking precedence over other peel count computations looks good to me

dmgreen added a subscriber: dmgreen.Apr 6 2018, 3:43 AM

Thanks everyone for the quick review. I'll commit shortly.

This revision was automatically updated to reflect the committed changes.