Page MenuHomePhabricator

Use sys::fs::real_path() instead of realpath() in Symbolize and remove HAVE_REALPATH.
AbandonedPublic

Authored by thakis on Apr 2 2018, 8:46 AM.

Details

Reviewers
samsonov
kcc
Summary

No intended behavior change.

Diff Detail

Event Timeline

thakis created this revision.Apr 2 2018, 8:46 AM

kcc, if samsonov no longer does llvm reviews, who can review this?

hans added a subscriber: hans.Apr 10 2018, 6:24 AM
hans added inline comments.
lib/DebugInfo/Symbolize/Symbolize.cpp
173

Yes, seems to be missing a not operator. I find std::error_code confusing.

Looks like this code has been removed in https://reviews.llvm.org/D57609, but I'm not sure the removal is correct (added a comment in that thread).

thakis abandoned this revision.Mar 20 2019, 9:34 AM

Made obsolete by D57609