This is an archive of the discontinued LLVM Phabricator instance.

Differential D45002

[test] Fix an XRay test on FreeBSD
ClosedPublic

Authored by lichray on Mar 28 2018, 3:17 PM.

Details

Reviewers
devnexen
krytarowski
dberris
Commits
rG0132baad7e0e: [test] Fix an XRay test on FreeBSD
rL328797: [test] Fix an XRay test on FreeBSD
rC328797: [test] Fix an XRay test on FreeBSD
Summary

Fixing clang-test on FreeBSD as a follow-up of https://reviews.llvm.org/D43378 to handle the revert happened in r325749.

Diff Detail

Repository
rC Clang

Event Timeline

lichray created this revision.Mar 28 2018, 3:17 PM
Herald added subscribers: dberris, emaste. · View Herald TranscriptMar 28 2018, 3:17 PM
devnexen added inline comments.Mar 28 2018, 3:58 PM
test/Driver/XRay/xray-instrument-os.c
2

What output do you get when you use directly llvm-lit on this ?

lichray added inline comments.Mar 28 2018, 4:32 PM
test/Driver/XRay/xray-instrument-os.c
2

Before:

clang -cc1 version 7.0.0 based upon LLVM 7.0.0svn default target x86_64-unknown-freebsd11.1
#include "..." search starts here:
#include <...> search starts here:
 [...]/llvm/build/lib/clang/7.0.0/include
 /usr/include
End of search list.

--

********************
Testing Time: 0.12s
********************
Failing Tests (1):
    Clang :: Driver/XRay/xray-instrument-os.c

  Unexpected Failures: 1

After:

lit: [...]llvm/utils/lit/lit/llvm/config.py:334: note: using clang: [...]/llvm/build/bin/clang
Testing Time: 0.11s
  Expected Failures  : 1
devnexen added a comment.Mar 29 2018, 3:43 AM

Looks ok to me except I would change a bit the title maybe.

devnexen added a reviewer: dberris.Mar 29 2018, 4:05 AM
lichray retitled this revision from [test] Conservatively re-enable a FreeBSD/XRay test to [test] Fix a XRay test on FreeBSD.Mar 29 2018, 8:45 AM
lichray retitled this revision from [test] Fix a XRay test on FreeBSD to [test] Fix an XRay test on FreeBSD.
devnexen added a comment.Mar 29 2018, 8:48 AM

Since I do not have commit permissions hopefully @dberris will come by or kamil if he s less busy.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 8:53 AM
Closed by commit rC328797: [test] Fix an XRay test on FreeBSD (authored by lichray). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Driver/
XRay/
2 lines

Diff 140264

test/Driver/XRay/xray-instrument-os.c

// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
// XFAIL: -linux- // XFAIL: -linux-, -freebsd
devnexenUnsubmitted
Not Done
ReplyInline Actions

What output do you get when you use directly llvm-lit on this ?

devnexen: What output do you get when you use directly llvm-lit on this ?
lichrayAuthorUnsubmitted
Not Done
ReplyInline Actions

Before:

clang -cc1 version 7.0.0 based upon LLVM 7.0.0svn default target x86_64-unknown-freebsd11.1
#include "..." search starts here:
#include <...> search starts here:
 [...]/llvm/build/lib/clang/7.0.0/include
 /usr/include
End of search list.

--

********************
Testing Time: 0.12s
********************
Failing Tests (1):
    Clang :: Driver/XRay/xray-instrument-os.c

  Unexpected Failures: 1

After:

lit: [...]llvm/utils/lit/lit/llvm/config.py:334: note: using clang: [...]/llvm/build/bin/clang
Testing Time: 0.11s
  Expected Failures  : 1
lichray: Before: ``` clang -cc1 version 7.0.0 based upon LLVM 7.0.0svn default target x86_64-unknown…
// REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64 // REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64
typedef int a; typedef int a;