[LNT] fix some typos/dead code

[danilaml]

Summary

Fix some typos/dead/unreachable code I've noticed while going through the LNT.

[danilaml]

ping

[MatzeB]

LGTM
Tgiugh this is another sign that the global_status view probably isn‘t used byanyone ans has no tests. I still think we should just remove it...

[danilaml]

In D45000#1078268, @MatzeB wrote:

Tgiugh this is another sign that the global_status view probably isn‘t used byanyone ans has no tests. I still think we should just remove it...

At least someone tried to use it somewhat recently: https://github.com/llvm-mirror/lnt/pull/2

Btw, I'm pretty sure I don't have a commit access.

[danilaml]

@MatzeB Is there something else I should do for this to be commited? First time using the Phabricator so I'm a bit unfamiliar with the process.

[danilaml]

@MatzeB ping

[kristof.beyls]

In D45000#1086160, @danilaml wrote:

@MatzeB Is there something else I should do for this to be commited? First time using the Phabricator so I'm a bit unfamiliar with the process.

Hi @danilaml,

The commit process is documented at https://llvm.org/docs/Phabricator.html#committing-a-change.
In short, if you don't have commit access, just ask someone with commit access to get it committed for you.
I can commit this patch for you, if you like?

[danilaml]

@kristof.beyls Thanks. Yes, I don't have commit access as I indicated in my previous reply (unless I was somehow given one without my knowledge). I'd be happy if you could commit this on my behalf.

lnt/server/ui/views.py

def v4_global_status():
     test_table = []
     for i, (test_id, test_name) in enumerate(reported_tests):
         # Create the row, starting with the test name and worst entry.
         row = [(test_id, test_name), None]
 
         # Compute comparison results for each machine.
         row.extend((runinfo.get_run_comparison_result(
                         run, baseline, test_id, field,
-                        ts.Sample.get_hash_of_Binary_field),
+                        ts.Sample.get_hash_of_binary_field),
                     run.id)
                    for baseline, run in machine_run_info)
 
         # Compute the worst cell value.
         if len(row) > 2:
             row[1] = max(cr.pct_delta
                          for cr, _ in row[2:])
 

lnt/tests/nt.py

def _process_reruns(config, server_reply, local_results):
     """
     try:
         server_results = server_reply['test_results'][0]['results']
     except KeyError:
         # Server might send us back an error.
         if server_reply.get('error', None):
             logger.warning("Server returned an error:" + server_reply['error'])
         fatal("No Server results. Cannot do reruns.")
-        logging.fatal()
     # Holds the combined local and server results.
     collated_results = dict()
 
     for b in local_results.tests:
         # format: suite.test/path/and/name.type<.type>
         fields = b.name.split('.')
         test_suite = fields[0]
 

lnt/util/ServerUtil.py

except Exception:
         print
         print "Traceback:"
         traceback.print_exc()
         print
         print "Result:"
         print "error:", result_data
         return
 
-    return reply
-
 
 def submitFileToInstance(path, file, select_machine=None, merge_run=None):
     # Otherwise, assume it is a local url and submit to the default database
     # in the instance.
     instance = lnt.server.instance.Instance.frompath(path)
     config = instance.config
     db_name = 'default'
     with contextlib.closing(config.get_database(db_name)) as db: