Page MenuHomePhabricator

Improving 'addArgumentAttrsFromCallsites'
Needs ReviewPublic

Authored by chamibuddhika on Mar 25 2018, 4:00 PM.

Details

Reviewers
nlopes
echristo
Summary

This patch aims to fix a TODO inside addArgumentAttrsFromCallsites method in function attribute inference code. This is more like a RFC patch where I need some feedback if the direction taken is valid. Idea was to introduce a PostDominatorTree argument to the method. It could be used to check if the callsite dominates the entry block and if so it is safe to transfer its callee attributes to the callers arguments.

This patch currently does *not* pass regression tests. I suspect this is due to an issue with how PostDominatorTree pass is introduced in the PassManager. I am still not completely familiar with how PassManager works.

Diff Detail

Repository
rL LLVM

Event Timeline

chamibuddhika created this revision.Mar 25 2018, 4:00 PM

Please don't remove non-functional changes from this patch. It contains dozens of indentation changes which are completely unrelated with the intended change and make the review more difficult. There are also debug printfs included that need to be removed :)
This document may be useful: http://llvm.org/docs/Contributing.html

Right. I will rework this and resubmit. Thanks.