This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Change std::sort to llvm::sort in response to r327219
ClosedPublic

Authored by mgrang on Mar 24 2018, 11:42 AM.

Details

Summary

r327219 added wrappers to std::sort which randomly shuffle the container before sorting.
This will help in uncovering non-determinism caused due to undefined sorting
order of objects having the same key.

To make use of that infrastructure we need to invoke llvm::sort instead of std::sort.

Note: This patch is one of a series of patches to replace *all* std::sort to llvm::sort.
Refer the comments section in D44363 for a list of all the required patches.

Diff Detail

Repository
rL LLVM

Event Timeline

mgrang created this revision.Mar 24 2018, 11:42 AM

SGTM but @sunfish should have the final say.

Ping for reviews please.

sunfish accepted this revision.Apr 9 2018, 11:25 AM

LGTM.

This revision is now accepted and ready to land.Apr 9 2018, 11:25 AM
This revision was automatically updated to reflect the committed changes.