Remap values in PromotedFloats

[yan_luo]

Summary

When a node is about to be erased from ReplacedValues, we should also remap its corresponding values in PromotedFloats.

[pirama]

The changes look good to me. But something is funny in Phabricator - I am unable to see the context in this file. How did you upload this CL?

[yan_luo]

I just copied and pasted the result of 'git diff'. Any step I should follow? First time use, sorry!

[lebedev.ri]

In D44872#1048404, @yan_luo wrote:

I just copied and pasted the result of 'git diff'. Any step I should follow? First time use, sorry!

https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Especially do note the -U999999

Though, it would be great if it would be actually enforced, see https://bugs.llvm.org/show_bug.cgi?id=36788

[yan_luo]

Thanks! I updated the diff, please review it again.

[pirama]

Thanks for the fix Yan.

[yan_luo]

BTW, I don't have commit access. Can you please help me land this fix? Thanks!

[pirama]

Done (328644). Cited in the commit message that you are the author since that gets overwritten when someone besides the author commits a change.

lib/CodeGen/SelectionDAG/LegalizeTypes.cpp

void DAGTypeLegalizer::ExpungeNode(SDNode *N) {
   // Remove N from all maps - this is expensive but rare.
 
   for (DenseMap<SDValue, SDValue>::iterator I = PromotedIntegers.begin(),
        E = PromotedIntegers.end(); I != E; ++I) {
     assert(I->first.getNode() != N);
     RemapValue(I->second);
   }
 
+  for (DenseMap<SDValue, SDValue>::iterator I = PromotedFloats.begin(),
+       E = PromotedFloats.end(); I != E; ++I) {
+    assert(I->first.getNode() != N);
+    RemapValue(I->second);
+  }
+
   for (DenseMap<SDValue, SDValue>::iterator I = SoftenedFloats.begin(),
        E = SoftenedFloats.end(); I != E; ++I) {
     assert(I->first.getNode() != N);
     RemapValue(I->second);
   }
 
   for (DenseMap<SDValue, SDValue>::iterator I = ScalarizedVectors.begin(),
        E = ScalarizedVectors.end(); I != E; ++I) {