This is an archive of the discontinued LLVM Phabricator instance.

Split the `throw_invoke_test.cc` test
ClosedPublic

Authored by delcypher on Mar 21 2018, 6:42 AM.

Details

Summary

[asan] Split the throw_invoke_test.cc into a Linux specific variant
and the general version to avoid use of libstdc++ on non-Linux
platforms.

This is motivated by the fact that using libstdc++ is deprecated on
Darwin and maybe removed some day.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Mar 21 2018, 6:42 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 21 2018, 6:42 AM

Hmm, that's basically duplicating the test case. Maybe you can #include "../throw_invoke_test.cc"?

Hmm, that's basically duplicating the test case. Maybe you can #include "../throw_invoke_test.cc"?

I actually did that originally but I decided I didn't like it because it creates a dependency between the two test files. I don't think there's any precedence for doing that.

I'll let @kcc have the final say as this is his test case originally.

@kcc @kubamracek Any thoughts? It's been a week so unless there are some objections I'd like to merge this soon.

kubamracek accepted this revision.Mar 28 2018, 8:10 AM

This looks good to me.

This revision is now accepted and ready to land.Mar 28 2018, 8:10 AM
This revision was automatically updated to reflect the committed changes.