Page MenuHomePhabricator

Change TSAN external symbolization API to support returning multiple frames
AcceptedPublic

Authored by asmundak on Mar 20 2018, 3:47 PM.

Details

Reviewers
dvyukov
Summary

New API passes a callback function to the external symbolizer, allowing it to add multiple frames to the traceback. Note that the old interface API will be still supported until the clients migrate to the new one.

Diff Detail

Event Timeline

asmundak created this revision.Mar 20 2018, 3:47 PM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. ยท View Herald TranscriptMar 20 2018, 3:47 PM
dvyukov accepted this revision.Mar 21 2018, 1:43 AM

Looks good. Comitting.

This revision is now accepted and ready to land.Mar 21 2018, 1:43 AM

Submitted in rev 328079.

This broke darwin build. I've fixed it up in:
http://llvm.org/viewvc/llvm-project?view=revision&revision=328082
Both external symbolization tests still pass, so I hope it works for your use case.

Sorry, I forgot (and don't know how) to build on Darwin.
Thanks for the help.