Page MenuHomePhabricator

[x32] Introduce -mx32 flag enforcing x32 mode for other triplets
ClosedPublic

Authored by pavel.v.chupin on Jul 11 2014, 4:38 AM.

Details

Summary

-mx32 flag setup target environment to GNUX32 and can be used for
other 32/64-bit triplets (i386-unknown-linux, x86_64-unknown-linux) to
turn on x32 mode. Compatible with GCC -mx32 flag.

Diff Detail

Repository
rL LLVM

Event Timeline

pavel.v.chupin retitled this revision from to [x32] Introduce -mx32 flag enforcing x32 mode for other triplets.
pavel.v.chupin updated this object.
pavel.v.chupin edited the test plan for this revision. (Show Details)
pavel.v.chupin added subscribers: zinovy.nis, dschuff, Unknown Object (MLST).
atanasyan edited edge metadata.Jul 11 2014, 5:12 AM

LGTM with a small nit

lib/Driver/Driver.cpp
1925 ↗(On Diff #11313)

AFAIK the -mx32 is applicable to X86/x86_64 targets only. Let's ignore it for other targets. As to me I would prefer to show an error if -m16 or -mx32 provided for any targets except X86/x86_64. But that is another story.

Thanks for quick response. I'll fix it before commit.

zinovy.nis closed this revision.Jul 11 2014, 7:37 AM
zinovy.nis updated this revision to Diff 11318.

Closed by commit rL212817 (authored by @zinovy.nis).