Page MenuHomePhabricator

pavel.v.chupin (Pavel Chupin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 6:14 AM (306 w, 6 d)

Recent Activity

Oct 1 2014

pavel.v.chupin added a comment to D5555: [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi.

LGTM, but I'd recommend to wait for other reviewers reply and/or add more reviewers who changed this code in the past.

Oct 1 2014, 9:34 AM

Sep 22 2014

pavel.v.chupin added a comment to D5245: [x32] Fix segmented stacks support.

Thanks. I'll fix formatting before commit.

Sep 22 2014, 6:20 AM

Sep 19 2014

pavel.v.chupin added a comment to D5245: [x32] Fix segmented stacks support.

Rafael,
Could you please review my patch? I see that in the past you did the major number of changes for the code I'm editing here.
Thanks.

Sep 19 2014, 5:52 AM

Sep 18 2014

pavel.v.chupin added a comment to D5245: [x32] Fix segmented stacks support.

Nadav, Rafael,

could you please take a look at this patch?

Thanks.

Sep 18 2014, 1:22 AM

Sep 15 2014

pavel.v.chupin updated the diff for D5355: [x32] Fix function indirect calls.

Sorry, but this patch should be better than previous version. Modified 1 more test to catch ineffectiveness I didn't noticed before.
We need zero-extend only if callee address is in register.
Please review.

Sep 15 2014, 9:32 AM
pavel.v.chupin retitled D5355: [x32] Fix function indirect calls from to [x32] Fix function indirect calls.
Sep 15 2014, 8:28 AM

Sep 8 2014

pavel.v.chupin retitled D5245: [x32] Fix segmented stacks support from to [x32] Fix segmented stacks support.
Sep 8 2014, 8:16 AM

Sep 5 2014

pavel.v.chupin retitled D5213: [x32] Emit callq for CALLpcrel32 from to [x32] Emit callq for CALLpcrel32.
Sep 5 2014, 6:53 AM

Aug 20 2014

pavel.v.chupin closed D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.

Closed by commit rL216065 (authored by pvchupin).

Aug 20 2014, 5:08 AM

Aug 19 2014

pavel.v.chupin updated the diff for D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.

Fixed

Aug 19 2014, 1:09 PM
pavel.v.chupin added inline comments to D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.
Aug 19 2014, 1:09 PM
pavel.v.chupin updated the diff for D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.

Fixed

Aug 19 2014, 12:00 PM
pavel.v.chupin added a comment to D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.

Ok. Actually I found couple of tests with sed (e.g. test/Transforms/GCOVProfiling/linezero.ll) so thought it's fine... not sure how they work though when no sed available. I'll change this test.

Aug 19 2014, 11:42 AM
pavel.v.chupin updated the diff for D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.

It's appeared that last version of patch is not correct because both needsStackRealignment and Opc == X86::LEA64_32r can be true at the same time. Making this check separate again and adding test revealing that.
Please review.

Aug 19 2014, 8:54 AM

Aug 18 2014

pavel.v.chupin updated the diff for D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr.

Modified code according review comments. Simplified a bit test case.

Aug 18 2014, 1:34 PM
pavel.v.chupin closed D4930: [x32] Handle -m64/-m32 switches by Driver in x32 mode.

Closed by commit rL215899 (authored by pvchupin).

Aug 18 2014, 8:47 AM

Aug 15 2014

pavel.v.chupin retitled D4930: [x32] Handle -m64/-m32 switches by Driver in x32 mode from to [x32] Handle -m64/-m32 switches by Driver in x32 mode.
Aug 15 2014, 9:31 AM
pavel.v.chupin retitled D4929: [x32] Fix FrameIndex check in SelectLEA64_32Addr from to [x32] Fix FrameIndex check in SelectLEA64_32Addr.
Aug 15 2014, 9:02 AM

Aug 7 2014

pavel.v.chupin closed D4617: [x32] Use ebp/esp as frame and stack pointer.

Closed by commit rL215091 (authored by pvchupin).

Aug 7 2014, 2:50 AM
pavel.v.chupin added a comment to D4617: [x32] Use ebp/esp as frame and stack pointer.

Thanks. I made corresponding changes.

Aug 7 2014, 2:44 AM

Aug 6 2014

pavel.v.chupin added a comment to D4617: [x32] Use ebp/esp as frame and stack pointer.

Hi Derek,
Can you please take a look at updated version?

Aug 6 2014, 1:42 AM

Aug 4 2014

pavel.v.chupin closed D4755: [x32] Add __int128 support.

Closed by commit rL214710 (authored by pvchupin).

Aug 4 2014, 5:48 AM

Aug 1 2014

pavel.v.chupin retitled D4755: [x32] Add __int128 support from to [x32] Add __int128 support.
Aug 1 2014, 7:30 AM

Jul 29 2014

pavel.v.chupin updated the diff for D4617: [x32] Use ebp/esp as frame and stack pointer.

Changed local vars names according last comments.
Updated test by adding nacl target case.

Jul 29 2014, 8:50 AM

Jul 22 2014

pavel.v.chupin retitled D4617: [x32] Use ebp/esp as frame and stack pointer from to [x32] Use ebp/esp as frame and stack pointer.
Jul 22 2014, 6:20 AM

Jul 14 2014

pavel.v.chupin closed D4473: [x32] Add __ILP32__ macro for ILP32 platforms.

Closed by commit rL212931 (authored by pvchupin).

Jul 14 2014, 3:06 AM

Jul 11 2014

pavel.v.chupin retitled D4473: [x32] Add __ILP32__ macro for ILP32 platforms from to [x32] Add __ILP32__ macro for ILP32 platforms.
Jul 11 2014, 7:48 AM
pavel.v.chupin added a comment to D4470: [x32] Introduce -mx32 flag enforcing x32 mode for other triplets.

Thanks for quick response. I'll fix it before commit.

Jul 11 2014, 7:03 AM
pavel.v.chupin retitled D4470: [x32] Introduce -mx32 flag enforcing x32 mode for other triplets from to [x32] Introduce -mx32 flag enforcing x32 mode for other triplets.
Jul 11 2014, 4:38 AM

Jul 10 2014

pavel.v.chupin added a comment to D4180: [x32] Add X32 support to driver.

Hi, it seems llvmdev discussion started week ago is over with some good comments made.
Can you please review this patch so we can proceed with these 2 patches merge and continue work on the next ones?

Jul 10 2014, 4:00 AM

Jul 6 2014

pavel.v.chupin updated the diff for D4180: [x32] Add X32 support to driver.

Added tests.
Redesigned findBiarchMultilibs for 3 arch (32,x32,64) support to pass more
tests.

Jul 6 2014, 7:27 AM

Jul 3 2014

pavel.v.chupin added a comment to D4180: [x32] Add X32 support to driver.

llvmdev thread: http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-July/074451.html
I'll add test.

Jul 3 2014, 1:29 AM

Jul 1 2014

pavel.v.chupin added a comment to D4181: [x32] Add X32 backend.

Thanks for comments.
I'll open new thread at llvmdev and provide some sort of roadmap and list of changes required.

Jul 1 2014, 12:17 PM
pavel.v.chupin added a comment to D4181: [x32] Add X32 backend.

Is it OK to commit?

Jul 1 2014, 5:11 AM

Jun 30 2014

pavel.v.chupin added a comment to D4181: [x32] Add X32 backend.

This is very minimal indeed.
I've got more raw changes, but want to split them first and polish for better review. Also working on tests.
I'm going to submit next patch very soon.

Jun 30 2014, 11:35 AM
pavel.v.chupin updated the diff for D4181: [x32] Add X32 backend.

Updating commit title

Jun 30 2014, 11:02 AM

Jun 27 2014

pavel.v.chupin added a reviewer for D4181: [x32] Add X32 backend: dschuff.
Jun 27 2014, 5:59 AM
pavel.v.chupin added a reviewer for D4180: [x32] Add X32 support to driver: dschuff.
Jun 27 2014, 5:58 AM
pavel.v.chupin added a reviewer for D4180: [x32] Add X32 support to driver: eliben.
Jun 27 2014, 5:53 AM
pavel.v.chupin added a reviewer for D4181: [x32] Add X32 backend: eliben.
Jun 27 2014, 5:51 AM

Jun 25 2014

pavel.v.chupin updated D4180: [x32] Add X32 support to driver.
Jun 25 2014, 10:45 AM
pavel.v.chupin updated D4181: [x32] Add X32 backend.
Jun 25 2014, 10:40 AM
pavel.v.chupin updated the diff for D4181: [x32] Add X32 backend.

Updating the commit message.

Jun 25 2014, 10:37 AM

Jun 19 2014

pavel.v.chupin updated the diff for D4180: [x32] Add X32 support to driver.

Fix couple minor formatting issues

Jun 19 2014, 5:43 AM
pavel.v.chupin updated the diff for D4180: [x32] Add X32 support to driver.

Changes after last review

Jun 19 2014, 5:31 AM
pavel.v.chupin added a comment to D4180: [x32] Add X32 support to driver.

Thanks for review. See next patchset.

Jun 19 2014, 5:28 AM

Jun 18 2014

pavel.v.chupin added a reviewer for D4181: [x32] Add X32 backend: jfb.
Jun 18 2014, 3:07 AM
pavel.v.chupin added reviewers for D4180: [x32] Add X32 support to driver: chandlerc, atanasyan.
Jun 18 2014, 2:57 AM

Jun 17 2014

pavel.v.chupin retitled D4181: [x32] Add X32 backend from to [x32] Add X32 backend.
Jun 17 2014, 10:31 AM
pavel.v.chupin retitled D4180: [x32] Add X32 support to driver from to [x32] Add X32 support to driver.
Jun 17 2014, 10:23 AM