- User Since
- Dec 4 2013, 6:14 AM (388 w, 7 h)
Oct 1 2014
LGTM, but I'd recommend to wait for other reviewers reply and/or add more reviewers who changed this code in the past.
Sep 22 2014
Thanks. I'll fix formatting before commit.
Sep 19 2014
Could you please review my patch? I see that in the past you did the major number of changes for the code I'm editing here.
Sep 18 2014
could you please take a look at this patch?
Sep 15 2014
Sorry, but this patch should be better than previous version. Modified 1 more test to catch ineffectiveness I didn't noticed before.
We need zero-extend only if callee address is in register.
Sep 8 2014
Sep 5 2014
Aug 20 2014
Closed by commit rL216065 (authored by pvchupin).
Aug 19 2014
Ok. Actually I found couple of tests with sed (e.g. test/Transforms/GCOVProfiling/linezero.ll) so thought it's fine... not sure how they work though when no sed available. I'll change this test.
It's appeared that last version of patch is not correct because both needsStackRealignment and Opc == X86::LEA64_32r can be true at the same time. Making this check separate again and adding test revealing that.
Aug 18 2014
Modified code according review comments. Simplified a bit test case.
Closed by commit rL215899 (authored by pvchupin).
Aug 15 2014
Aug 7 2014
Closed by commit rL215091 (authored by pvchupin).
Thanks. I made corresponding changes.
Aug 6 2014
Can you please take a look at updated version?
Aug 4 2014
Closed by commit rL214710 (authored by pvchupin).
Aug 1 2014
Jul 29 2014
Changed local vars names according last comments.
Updated test by adding nacl target case.
Jul 22 2014
Jul 14 2014
Closed by commit rL212931 (authored by pvchupin).
Jul 11 2014
Thanks for quick response. I'll fix it before commit.
Jul 10 2014
Hi, it seems llvmdev discussion started week ago is over with some good comments made.
Can you please review this patch so we can proceed with these 2 patches merge and continue work on the next ones?
Jul 6 2014
Redesigned findBiarchMultilibs for 3 arch (32,x32,64) support to pass more
Jul 3 2014
llvmdev thread: http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-July/074451.html
I'll add test.
Jul 1 2014
Thanks for comments.
I'll open new thread at llvmdev and provide some sort of roadmap and list of changes required.
Is it OK to commit?
Jun 30 2014
This is very minimal indeed.
I've got more raw changes, but want to split them first and polish for better review. Also working on tests.
I'm going to submit next patch very soon.
Updating commit title
Jun 27 2014
Jun 25 2014
Updating the commit message.
Jun 19 2014
Fix couple minor formatting issues
Changes after last review
Thanks for review. See next patchset.