This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizer] Allow builtins for Cross-DSO CFI on Android
ClosedPublic

Authored by phosek on Mar 19 2018, 5:22 PM.

Details

Summary

This is needed to avoid the test failure in case when compiler-rt
is set as the default runtime library for Clang.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Mar 19 2018, 5:22 PM
eugenis accepted this revision.Mar 19 2018, 5:34 PM

See my comment in https://reviews.llvm.org/D44655, but this change is also fine with me.

This revision is now accepted and ready to land.Mar 19 2018, 5:34 PM

That link seems to be pointing to this change?

I was actually thinking about doing the same now, more specifically using -rtlib=platform which is already used elsewhere in this test. Do you prefer one or the other?

Since the test is about cfi, not builtins, I think it's better to check for the cfi library explicitly.

phosek updated this revision to Diff 139062.Mar 19 2018, 5:53 PM

SGTM, I've made the test even more explicit.

eugenis accepted this revision.Mar 19 2018, 5:55 PM

LGTM

This revision was automatically updated to reflect the committed changes.