This is an archive of the discontinued LLVM Phabricator instance.

Differential D44628

Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs
ClosedPublic

Authored by ilya-biryukov on Mar 19 2018, 8:05 AM.

Details

Reviewers
alexfh
simark
Commits
rG3f0ea37b8763: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs
rC327984: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs
rL327984: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs
Summary

LLVM .clang_tidy seems to be more up-to-date.

Diff Detail

Event Timeline

ilya-biryukov created this revision.Mar 19 2018, 8:05 AM
ilya-biryukov added a subscriber: simark.Mar 19 2018, 8:05 AM

Found by @simark while working on D44272.

Harbormaster completed remote builds in B16203: Diff 138931.Mar 19 2018, 8:06 AM
simark accepted this revision.Mar 19 2018, 8:17 AM
This revision is now accepted and ready to land.Mar 19 2018, 8:17 AM
ilya-biryukov mentioned this in D44272: [clangd] Support incremental document syncing.Mar 19 2018, 8:32 AM
simark requested changes to this revision.Mar 19 2018, 8:46 AM
simark added inline comments.
.clang-tidy
8

In practice, don't we use CamelCase for functions?

This revision now requires changes to proceed.Mar 19 2018, 8:46 AM
ilya-biryukov added inline comments.Mar 20 2018, 2:37 AM
.clang-tidy
8

No, functions should be camelCase. I've seen some violations, but the style guide seems to be clear:

Function names should be verb phrases (as they represent actions), and command-like function should be imperative. The name should be camel case, and start with a lower case letter (e.g. openFile() or isFoo()).

alexfh accepted this revision.Mar 20 2018, 7:31 AM

Thanks! I don't know how useful is the support of cfe being checked out somewhere else than into llvm/tools/clang. If we could give up on that, we could just kill this file and rely on clang-tidy to pick up llvm/.clang-tidy.

Anyways, LG.

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 20 2018, 7:41 AM
Closed by commit rL327984: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs (authored by ibiryukov). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptMar 20 2018, 7:41 AM

Revision Contents

PathSize
7 lines

Diff 138931

.clang-tidy

Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming' Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
CheckOptions: CheckOptions:
- key: readability-identifier-naming.ClassCase - key: readability-identifier-naming.ClassCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.EnumCase - key: readability-identifier-naming.EnumCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.FunctionCase - key: readability-identifier-naming.FunctionCase
value: lowerCase value: camelBack
simarkUnsubmitted
Not Done
ReplyInline Actions

In practice, don't we use CamelCase for functions?

simark: In practice, don't we use `CamelCase` for functions?
ilya-biryukovAuthorUnsubmitted
Not Done
ReplyInline Actions

No, functions should be camelCase. I've seen some violations, but the style guide seems to be clear:

Function names should be verb phrases (as they represent actions), and command-like function should be imperative. The name should be camel case, and start with a lower case letter (e.g. openFile() or isFoo()).

ilya-biryukov: No, functions should be `camelCase`. I've seen some violations, but [[https://llvm.
- key: readability-identifier-naming.MemberCase
value: CamelCase
- key: readability-identifier-naming.ParameterCase
value: CamelCase
- key: readability-identifier-naming.UnionCase - key: readability-identifier-naming.UnionCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.VariableCase - key: readability-identifier-naming.VariableCase
value: CamelCase value: CamelCase