Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

[ilya-biryukov]

Summary

LLVM .clang_tidy seems to be more up-to-date.

[ilya-biryukov]

Found by @simark while working on D44272.

[simark]

.clang-tidy

8 ↗

(On Diff #138931)

In practice, don't we use CamelCase for functions?

[ilya-biryukov]

.clang-tidy

8 ↗

(On Diff #138931)

No, functions should be camelCase. I've seen some violations, but the style guide seems to be clear:

Function names should be verb phrases (as they represent actions), and command-like function should be imperative. The name should be camel case, and start with a lower case letter (e.g. openFile() or isFoo()).

[alexfh]

Thanks! I don't know how useful is the support of cfe being checked out somewhere else than into llvm/tools/clang. If we could give up on that, we could just kill this file and rely on clang-tidy to pick up llvm/.clang-tidy.

Anyways, LG.

cfe/trunk/.clang-tidy

 Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase
   - key:             readability-identifier-naming.EnumCase
     value:           CamelCase
   - key:             readability-identifier-naming.FunctionCase
-    value:           lowerCase
+    value:           camelBack
+  - key:             readability-identifier-naming.MemberCase
+    value:           CamelCase
+  - key:             readability-identifier-naming.ParameterCase
+    value:           CamelCase
   - key:             readability-identifier-naming.UnionCase
     value:           CamelCase
   - key:             readability-identifier-naming.VariableCase
     value:           CamelCase
+