This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Make __start_/__stop_<section_name> symbols STV_PROTECTED
ClosedPublic

Authored by grimar on Mar 16 2018, 7:23 AM.

Diff Detail

Event Timeline

grimar created this revision.Mar 16 2018, 7:23 AM
espindola accepted this revision.Mar 19 2018, 10:09 AM

LGTM
I am actually surprised these are not hidden.

This revision is now accepted and ready to land.Mar 19 2018, 10:09 AM
ruiu accepted this revision.Mar 19 2018, 11:09 AM

LGTM

espindola accepted this revision.
espindola added a comment.
This revision is now accepted and ready to land.

LGTM
I am actually surprised these are not hidden.

https://reviews.llvm.org/D44566

Yes, Binutils initially made them hidden but had to change to protected
because of https://sourceware.org/bugzilla/show_bug.cgi?id=21964.
(http://lists.gnu.org/archive/html/bug-binutils/2017-08/msg00195.html)

George.

This revision was automatically updated to reflect the committed changes.