Page MenuHomePhabricator

Remove unnecessary include from Driver.cpp
Needs ReviewPublic

Authored by yamaguchi on Mar 15 2018, 1:28 AM.



Clang compiles and test passes without these includes.

Diff Detail

Event Timeline

yamaguchi created this revision.Mar 15 2018, 1:28 AM

Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain.
Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but D44509 seems like a possibly overzealous application?

yamaguchi updated this revision to Diff 138671.Mar 16 2018, 1:32 AM

@marsupial Thanks for the commment, found a bug in my script and fixed. Now this patch removes only includes which are not used in each TU.