This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Copy system debugserver from the right place when only CommandLineTools are installed
ClosedPublic

Authored by xiaobai on Mar 14 2018, 10:53 PM.

Details

Summary

Instead of building debugserver when building lldb, I'd rather pass
LLDB_CODESIGN_IDENTITY="" to cmake and use the one already on my system.
However, on one of my machines I only have the CommandLineTools installed, and
so the hardcoded path to the system debugserver does not work for me.
Additionally, we should verify the LLDB framework exists on the machine before
trying to set the path to debugserver. This allows us to warn the user at
configure time that a system debugserver can't be found if they choose not to
build it themselves.

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.Mar 14 2018, 10:53 PM
vsk accepted this revision.Mar 15 2018, 10:52 AM

Thank you, lgtm.

This revision is now accepted and ready to land.Mar 15 2018, 10:52 AM

@vsk Would you mind committing this for me when you get the chance? I don't have commit access. :)

This revision was automatically updated to reflect the committed changes.