This is an archive of the discontinued LLVM Phabricator instance.

[UpdateTestChecks] Handle IR variables with a '-' in the name
ClosedPublic

Authored by arichardson on Mar 14 2018, 2:35 AM.

Details

Summary

I noticed that clang will emit variables such as %indirect-arg-temp when
running update_cc1_test_checks.py and therefore update_cc1_test_checks.py
wasn't adding FileCheck captures for those variables.

Diff Detail

Repository
rL LLVM

Event Timeline

arichardson created this revision.Mar 14 2018, 2:35 AM
MaskRay accepted this revision.Mar 14 2018, 10:56 AM

It is named update_cc_test_checks.py. But do you think update_cc1_test_checks.py is a better name?

This revision is now accepted and ready to land.Mar 14 2018, 10:56 AM

It is named update_cc_test_checks.py. But do you think update_cc1_test_checks.py is a better name?

I've fixed the typo in my commit message. I think either name is fine (or even update_clang_test_checks.py).

This revision was automatically updated to reflect the committed changes.