Page MenuHomePhabricator

Treat libclang_rt.* as normal library if the user uses --sysroot=
Needs ReviewPublic

Authored by trixirt on Mar 13 2018, 2:11 PM.

Details

Summary

In cross compiling, one normally assumes that the user supplied sysroot contains all of the libraries needed in the link. And so the linker adjusts the -L paths to look in the sysroot.
However because libclang_rt.* is supplied at link time as a full path, the link can not find it in the sysroot.

This change will churn the user's current experience and the unit tests.
I will take take of the tests, if folks are ok with the change.

Diff Detail

Repository
rC Clang

Event Timeline

trixirt created this revision.Mar 13 2018, 2:11 PM

Will it work on Windows? If sysroot is provided, Prefix is "-l", but I'm not sure that link.exe accepts "-l" notation.