Page MenuHomePhabricator

[ELF] - Convert overlapping-sections.s testcase to x86 and cleanup.
ClosedPublic

Authored by grimar on Mar 13 2018, 9:54 AM.

Details

Summary

Patch do the following change:

  • Test case was converted from MIPS to x86. Not sure why it was done as MIPS initially, but since it had TODO comment saying we can switch to x86, I did that.
  • Does not seem to make sense to check "good" output in this test case. We check that our output is good in many other tests and intention of this one is only to check we are still able to report overlaps and/or produce broken output with overlaps I think. So I removed that part of the test.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Mar 13 2018, 9:54 AM
This revision is now accepted and ready to land.Mar 13 2018, 11:06 AM
arichardson accepted this revision.Mar 13 2018, 2:57 PM

LGTM

The reason that this is a MIPS test case is that I work on CHERI (which extends MIPS) and therefore most of the testcases I write are derived from MIPS input.

This revision was automatically updated to reflect the committed changes.