This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Reorder synthetic functions to come first
ClosedPublic

Authored by ncw on Mar 9 2018, 3:50 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

ncw created this revision.Mar 9 2018, 3:50 PM
sbc100 accepted this revision.Mar 9 2018, 4:51 PM

Thanks!

Sad that so much test output changes when we that. Perhaps its inevitable for this kind of change, but perhaps our tests could be less fragile too. Maybe once we have the good disassembly this will be a better format for checking against.

This revision is now accepted and ready to land.Mar 9 2018, 4:51 PM
ncw added a comment.Mar 10 2018, 8:11 AM

Thanks. We could consider sorting the type section (lexicographically by result/arg types) so at least we don't have to renumber all the type relocations through our test files when two functions swap order. Currently the types are ordered by functions that use them.

I'll put that on my todo list, although I don't really relish the thought of the test updates that would accompany that change when it's introduced...!

This revision was automatically updated to reflect the committed changes.