This is an archive of the discontinued LLVM Phabricator instance.

Add FreeBSD support to the address sanitizer's waitid.cc test case
ClosedPublic

Authored by kutuzov.viktor.84 on Jul 8 2014, 5:57 AM.

Reviewers

kcc
samsonov

Commits

kutuzov.viktor.84 retitled this revision from to Add FreeBSD support to the address sanitizer's waitid.cc test case.

kutuzov.viktor.84 updated this object.

kutuzov.viktor.84 edited the test plan for this revision. (Show Details)

kutuzov.viktor.84 added subscribers: Unknown Object (MLST), theraven, emaste.

can/should we include signal.h unconditionally?

Right, <signal.h> should be available on both Linux, Darwin and FreeBSD.

LGTM

test/asan/TestCases/Posix/waitid.cc
7	Please sort the includes (unless this order is necessary for FreeBSD).

This revision is now accepted and ready to land.Jul 17 2014, 11:46 AM

Closed by commit rL213368 (authored by vkutuzov).

Path

Size

test/

asan/

TestCases/

Posix/

1 line

	// RUN: %clangxx_asan -O0 %s -o %t && not %run %t 2>&1 \| FileCheck %s			// RUN: %clangxx_asan -O0 %s -o %t && not %run %t 2>&1 \| FileCheck %s
	// RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 \| FileCheck %s			// RUN: %clangxx_asan -O3 %s -o %t && not %run %t 2>&1 \| FileCheck %s

	#include <assert.h>			#include <assert.h>
	#include <sys/wait.h>			#include <sys/wait.h>
	#include <unistd.h>			#include <unistd.h>
				#include <signal.h>
				samsonovUnsubmitted Not Done Reply Inline Actions Please sort the includes (unless this order is necessary for FreeBSD). samsonov: Please sort the includes (unless this order is necessary for FreeBSD).

	int main(int argc, char **argv) {			int main(int argc, char **argv) {
	pid_t pid = fork();			pid_t pid = fork();
	if (pid) { // parent			if (pid) { // parent
	int x[3];			int x[3];
	int status = x + argc 3;			int status = x + argc 3;
	int res;			int res;

	Show All 13 Lines