Page MenuHomePhabricator

[WebAssembly] Disallow weak undefined globals in the object format
ClosedPublic

Authored by ncw on Mar 7 2018, 4:15 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ncw created this revision.Mar 7 2018, 4:15 AM
sbc100 accepted this revision.Mar 7 2018, 9:59 AM

LGTM, with comments.

lib/Object/WasmObjectFile.cpp
426 ↗(On Diff #137361)

Add and test for this error maybe?

Should the error be more specific?

Do we also want to add an error to MC/WasmObjectWriter.cpp?

This revision is now accepted and ready to land.Mar 7 2018, 9:59 AM
This revision was automatically updated to reflect the committed changes.
ncw marked an inline comment as done.
ncw added inline comments.Mar 9 2018, 8:33 AM
lib/Object/WasmObjectFile.cpp
426 ↗(On Diff #137361)

Done, on all three counts.