Page MenuHomePhabricator

[SampleFDO] Extend SampleProfReader to handle demangled names
ClosedPublic

Authored by wmi on Mar 6 2018, 9:33 AM.

Details

Summary

SampleProfReader assumes function names in the profile are all mangled names. However, there are cases that few demangled names are somehow contained in the profile (usually because of debug info problems), which may trigger parsing error in SampleProfReader and cause the whole profile to be unusable. The patch extends SampleProfReader to handle profiles with demangled names, so that those profiles can still be useful.

Diff Detail

Repository
rL LLVM

Event Timeline

wmi created this revision.Mar 6 2018, 9:33 AM
danielcdh accepted this revision.Mar 6 2018, 11:02 AM

Just to confirm, this only applies to text format. Binary format should not have this problem, right?

This revision is now accepted and ready to land.Mar 6 2018, 11:02 AM
wmi added a comment.Mar 6 2018, 11:09 AM

Right, binary format does not have this problem.

This revision was automatically updated to reflect the committed changes.