Details
Diff Detail
- Repository
- rCRT Compiler Runtime
Event Timeline
Are you going to move strxfrm into common as well? In the different patch?
If not, I'll move it myself, for consistency.
lib/sanitizer_common/sanitizer_common_interceptors.inc | ||
---|---|---|
6536 | sizeof(wchar_t) * (REAL(wcslen)(src) + 1) | |
6539 | Please remove {} | |
6550 | sizeof(wchar_t) * (REAL(wcslen)(src) + 1) | |
test/msan/wcsxfrm.cc | ||
12 | you may try to add test case where it catches poisoned bytes in the src string. |
Thanks!
And oops, missed your comment about strxfrm. I can move that in a subsequent patch if you haven't already started doing that.
Hi, this seems to be failing at http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/43377/console. Can you take a look?
Hmm, looks like we might need "#include <xlocale.h>" when compiling on macos for both compiler-rt/test/sanitizer_common/TestCases/Posix/strxfrm.c and compiler-rt/test/sanitizer_common/TestCases/Posix/wcsxfrm.c ?
sizeof(wchar_t) * (REAL(wcslen)(src) + 1)