Page MenuHomePhabricator

[lldb] Add synthetic frontend for _NSCallStackArray
ClosedPublic

Authored by kubamracek on Mar 4 2018, 7:07 PM.

Details

Summary

An Obj-C array type _NSCallStackArray is used in NSException backtraces. This patch adds a synthetic frontend for _NSCallStackArray, which now correctly returns frame PCs.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

kubamracek created this revision.Mar 4 2018, 7:07 PM
davide requested changes to this revision.Nov 12 2018, 7:48 AM
davide added inline comments.
source/Plugins/Language/ObjC/NSArray.cpp
444–449

Can you add a comment here?
this also seems exactly the same as NSArrayCF, any chance we can avoid the duplication?

This revision now requires changes to proceed.Nov 12 2018, 7:48 AM
kubamracek marked an inline comment as done.
kubamracek added inline comments.
source/Plugins/Language/ObjC/NSArray.cpp
444–449

Added comment and de-duplicated the branch.

davide accepted this revision.Nov 12 2018, 10:54 AM

Thanks for addressing my comments.

This revision is now accepted and ready to land.Nov 12 2018, 10:54 AM
This revision was automatically updated to reflect the committed changes.