This is an archive of the discontinued LLVM Phabricator instance.

Paths

[WebAssembly] Fix reportUndefinedUndefines.
AbandonedPublic

Authored by ruiu on Feb 27 2018, 5:14 PM.

Reviewers

sbc100

Summary

No test fails with this change. Do we need this condition?

Build Status

Buildable 15495
Build 15495: arc lint + arc unit

Yes, looks like we need to add this case to test/wasm/undefined.ll

I'm looking at adding this now.. just FYI.

ruiu abandoned this revision.Feb 27 2018, 5:30 PM

Path

Size

lld/

wasm/

3 lines

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines	if (Undefs.empty())
return;		return;

for (ObjFile *File : ObjectFiles)		for (ObjFile *File : ObjectFiles)
for (Symbol *Sym : File->getSymbols())		for (Symbol *Sym : File->getSymbols())
if (Undefs.count(Sym))		if (Undefs.count(Sym))
error(toString(File) + ": undefined symbol: " + toString(*Sym));		error(toString(File) + ": undefined symbol: " + toString(*Sym));

for (Symbol *Sym : Undefs)		for (Symbol *Sym : Undefs)
if (!Sym->getFile())
error("undefined symbol: " + toString(*Sym));		error("undefined symbol: " + toString(*Sym));
}		}

Symbol *SymbolTable::find(StringRef Name) {		Symbol *SymbolTable::find(StringRef Name) {
auto It = SymMap.find(CachedHashStringRef(Name));		auto It = SymMap.find(CachedHashStringRef(Name));
if (It == SymMap.end())		if (It == SymMap.end())
return nullptr;		return nullptr;
return It->second;		return It->second;
}		}
▲ Show 20 Lines • Show All 266 Lines • Show Last 20 Lines