This is an archive of the discontinued LLVM Phabricator instance.

Differential D43709

[WebAssembly] Remove redundant local variables.
ClosedPublic

Authored by ruiu on Feb 23 2018, 6:08 PM.

Details

Reviewers
sbc100
Commits
rG319eb8b3c36f: [WebAssembly] Remove redundant local variables.
rLLD326280: [WebAssembly] Remove redundant local variables.
rL326280: [WebAssembly] Remove redundant local variables.
Summary

[WebAssembly] Remove redundant local variables.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.Feb 23 2018, 6:08 PM
Herald added subscribers: sunfish, aheejin, jgravelle-google and 2 others. · View Herald TranscriptFeb 23 2018, 6:08 PM
Harbormaster completed remote builds in B15387: Diff 135756.Feb 23 2018, 6:09 PM
sbc100 accepted this revision.Feb 27 2018, 1:08 PM
This revision is now accepted and ready to land.Feb 27 2018, 1:08 PM
Closed by commit rL326280: [WebAssembly] Remove redundant local variables. (authored by ruiu). · Explain WhyFeb 27 2018, 4:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
wasm/
15 lines

Diff 136185

lld/trunk/wasm/OutputSections.cpp

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Linesvoid CodeSection::writeTo(uint8_t *Buf) {
log(" headersize=" + Twine(Header.size())); log(" headersize=" + Twine(Header.size()));
log(" codeheadersize=" + Twine(CodeSectionHeader.size())); log(" codeheadersize=" + Twine(CodeSectionHeader.size()));
Buf += Offset; Buf += Offset;
// Write section header // Write section header
memcpy(Buf, Header.data(), Header.size()); memcpy(Buf, Header.data(), Header.size());
Buf += Header.size(); Buf += Header.size();
uint8_t *ContentsStart = Buf;
// Write code section headers // Write code section headers
memcpy(Buf, CodeSectionHeader.data(), CodeSectionHeader.size()); memcpy(Buf, CodeSectionHeader.data(), CodeSectionHeader.size());
Buf += CodeSectionHeader.size();
// Write code section bodies // Write code section bodies
parallelForEach(Functions, [ContentsStart](const InputChunk *Chunk) { parallelForEach(Functions, [&](const InputChunk *Chunk) {
Chunk->writeTo(ContentsStart); Chunk->writeTo(Buf);
}); });
} }
uint32_t CodeSection::numRelocations() const { uint32_t CodeSection::numRelocations() const {
uint32_t Count = 0; uint32_t Count = 0;
for (const InputChunk *Func : Functions) for (const InputChunk *Func : Functions)
Count += Func->NumRelocations(); Count += Func->NumRelocations();
return Count; return Count;
Show All 36 Linesvoid DataSection::writeTo(uint8_t *Buf) {
log("writing " + toString(*this) + " size=" + Twine(getSize()) + log("writing " + toString(*this) + " size=" + Twine(getSize()) +
" body=" + Twine(BodySize)); " body=" + Twine(BodySize));
Buf += Offset; Buf += Offset;
// Write section header // Write section header
memcpy(Buf, Header.data(), Header.size()); memcpy(Buf, Header.data(), Header.size());
Buf += Header.size(); Buf += Header.size();
uint8_t *ContentsStart = Buf;
// Write data section headers // Write data section headers
memcpy(Buf, DataSectionHeader.data(), DataSectionHeader.size()); memcpy(Buf, DataSectionHeader.data(), DataSectionHeader.size());
parallelForEach(Segments, [ContentsStart](const OutputSegment *Segment) { parallelForEach(Segments, [&](const OutputSegment *Segment) {
// Write data segment header // Write data segment header
uint8_t *SegStart = ContentsStart + Segment->getSectionOffset(); uint8_t *SegStart = Buf + Segment->getSectionOffset();
memcpy(SegStart, Segment->Header.data(), Segment->Header.size()); memcpy(SegStart, Segment->Header.data(), Segment->Header.size());
// Write segment data payload // Write segment data payload
for (const InputChunk *Chunk : Segment->InputSegments) for (const InputChunk *Chunk : Segment->InputSegments)
Chunk->writeTo(ContentsStart); Chunk->writeTo(Buf);
}); });
} }
uint32_t DataSection::numRelocations() const { uint32_t DataSection::numRelocations() const {
uint32_t Count = 0; uint32_t Count = 0;
for (const OutputSegment *Seg : Segments) for (const OutputSegment *Seg : Segments)
for (const InputChunk *InputSeg : Seg->InputSegments) for (const InputChunk *InputSeg : Seg->InputSegments)
Count += InputSeg->NumRelocations(); Count += InputSeg->NumRelocations();
return Count; return Count;
} }
void DataSection::writeRelocations(raw_ostream &OS) const { void DataSection::writeRelocations(raw_ostream &OS) const {
for (const OutputSegment *Seg : Segments) for (const OutputSegment *Seg : Segments)
for (const InputChunk *C : Seg->InputSegments) for (const InputChunk *C : Seg->InputSegments)
C->writeRelocations(OS); C->writeRelocations(OS);
} }