Page MenuHomePhabricator

Fix TestUbsanBasic
ClosedPublic

Authored by friss on Feb 21 2018, 7:57 AM.

Details

Summary

Potentially due to the recent testuite refactorings, this test now reports
a full absolute path but expect just the filename. For some reason this
test is skipped on GreenDragon so we've never seen the issue.

Diff Detail

Repository
rL LLVM

Event Timeline

friss created this revision.Feb 21 2018, 7:57 AM
davide added a subscriber: davide.Feb 21 2018, 9:29 AM

I wonder whether we could use something like

>>> import os
>>> os.path.basename('/patatino/ino/main.c')
'main.c'

to make this slightly more robust against files which end in main.c but we don't want to really match, e.g. blahmain.c.

vsk accepted this revision.Feb 21 2018, 10:56 AM

I'd be fine with this version of the patch, or one which uses path.basename to be more stringent.

This test is skipped on green dragon because I have not upstreamed the debugger integration for ubsan in compiler-rt yet.

This revision is now accepted and ready to land.Feb 21 2018, 10:56 AM
Closed by commit rL325859: Fix TestUbsanBasic (authored by friss, committed by ). · Explain WhyFeb 22 2018, 9:05 PM
This revision was automatically updated to reflect the committed changes.