This is an archive of the discontinued LLVM Phabricator instance.

Differential D43545

[Driver] Make -fno-common default for Fuchsia
ClosedPublic

Authored by phosek on Feb 20 2018, 8:39 PM.

Details

Reviewers
mcgrathr
jakehehrlich
Commits
rGbf45ecef6698: [Driver] Make -fno-common default for Fuchsia
rC325945: [Driver] Make -fno-common default for Fuchsia
rL325945: [Driver] Make -fno-common default for Fuchsia
Summary

We never want to generate common symbols on Fuchsia.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Feb 20 2018, 8:39 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptFeb 20 2018, 8:39 PM
jakehehrlich accepted this revision.Feb 21 2018, 1:50 PM

LGTM

This revision is now accepted and ready to land.Feb 21 2018, 1:50 PM
Closed by commit rL325945: [Driver] Make -fno-common default for Fuchsia (authored by phosek). · Explain WhyFeb 23 2018, 12:12 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 23 2018, 12:12 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
2 lines
test/
Driver/
1 line

Diff 135193

clang/lib/Driver/ToolChains/Clang.cpp

Show First 20 Lines • Show All 1,300 Lines • ▼ Show 20 Linesstatic bool isSignedCharDefault(const llvm::Triple &Triple) {
case llvm::Triple::xcore: case llvm::Triple::xcore:
return false; return false;
} }
} }
static bool isNoCommonDefault(const llvm::Triple &Triple) { static bool isNoCommonDefault(const llvm::Triple &Triple) {
switch (Triple.getArch()) { switch (Triple.getArch()) {
default: default:
if (Triple.isOSFuchsia())
return true;
return false; return false;
case llvm::Triple::xcore: case llvm::Triple::xcore:
case llvm::Triple::wasm32: case llvm::Triple::wasm32:
case llvm::Triple::wasm64: case llvm::Triple::wasm64:
return true; return true;
} }
} }
▲ Show 20 Lines • Show All 4,271 Lines • Show Last 20 Lines

clang/test/Driver/fuchsia.c

// RUN: %clang %s -### -no-canonical-prefixes --target=x86_64-unknown-fuchsia \ // RUN: %clang %s -### -no-canonical-prefixes --target=x86_64-unknown-fuchsia \
// RUN: --sysroot=%S/platform 2>&1 \ // RUN: --sysroot=%S/platform 2>&1 \
// RUN: | FileCheck -check-prefixes=CHECK,CHECK-X86_64 %s // RUN: | FileCheck -check-prefixes=CHECK,CHECK-X86_64 %s
// RUN: %clang %s -### -no-canonical-prefixes --target=aarch64-unknown-fuchsia \ // RUN: %clang %s -### -no-canonical-prefixes --target=aarch64-unknown-fuchsia \
// RUN: --sysroot=%S/platform 2>&1 \ // RUN: --sysroot=%S/platform 2>&1 \
// RUN: | FileCheck -check-prefixes=CHECK,CHECK-AARCH64 %s // RUN: | FileCheck -check-prefixes=CHECK,CHECK-AARCH64 %s
// CHECK: {{.*}}clang{{.*}}" "-cc1" // CHECK: {{.*}}clang{{.*}}" "-cc1"
// CHECK: "--mrelax-relocations" // CHECK: "--mrelax-relocations"
// CHECK: "-munwind-tables" // CHECK: "-munwind-tables"
// CHECK: "-fuse-init-array" // CHECK: "-fuse-init-array"
// CHECK: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include" // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
// CHECK: "-fno-common"
// CHECK: {{.*}}ld.lld{{.*}}" "-z" "rodynamic" // CHECK: {{.*}}ld.lld{{.*}}" "-z" "rodynamic"
// CHECK: "--sysroot=[[SYSROOT]]" // CHECK: "--sysroot=[[SYSROOT]]"
// CHECK: "-pie" // CHECK: "-pie"
// CHECK: "--build-id" // CHECK: "--build-id"
// CHECK: "--hash-style=gnu" // CHECK: "--hash-style=gnu"
// CHECK: "-dynamic-linker" "ld.so.1" // CHECK: "-dynamic-linker" "ld.so.1"
// CHECK: Scrt1.o // CHECK: Scrt1.o
// CHECK-NOT: crti.o // CHECK-NOT: crti.o
▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines