[scudo] Make some tests less Linux-y

[cryptoad]

Summary

Start making the Scudo tests less Linux-y:

• malloc_usable_size doesn't exist everywhere, so replace them with __sanitizer_get_allocated_size which we provide;
• move all the memalign related tests into memalign.c since it's also not available everywhere.

I also noticed that the memalign.c was missing a line in one of the loops.

test/scudo/double-free.cpp

 // RUN: %clangxx_scudo %s -o %t
 // RUN: not %run %t malloc   2>&1 | FileCheck %s
 // RUN: not %run %t new      2>&1 | FileCheck %s
 // RUN: not %run %t newarray 2>&1 | FileCheck %s
-// RUN: not %run %t memalign 2>&1 | FileCheck %s
 
 // Tests double-free error on pointers allocated with different allocation
 // functions.
 
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
 
if (!strcmp(argv[1], "new")) {
     delete p;
   }
   if (!strcmp(argv[1], "newarray")) {
     int *p = new int[8];
     assert(p);
     delete[] p;
     delete[] p;
   }
-  if (!strcmp(argv[1], "memalign")) {
-    void *p = nullptr;
-    posix_memalign(&p, 0x100, sizeof(int));
-    assert(p);
-    free(p);
-    free(p);
-  }
   return 0;
 }
 
 // CHECK: ERROR: invalid chunk state

test/scudo/memalign.c

 // RUN: %clang_scudo %s -o %t
-// RUN:                                                 %run %t valid   2>&1
-// RUN:                                             not %run %t invalid 2>&1
-// RUN: %env_scudo_opts=allocator_may_return_null=1     %run %t invalid 2>&1
+// RUN:                                                 %run %t valid       2>&1
+// RUN:                                             not %run %t invalid     2>&1
+// RUN: %env_scudo_opts=allocator_may_return_null=1     %run %t invalid     2>&1
+// RUN:                                             not %run %t double-free 2>&1 | FileCheck --check-prefix=CHECK-double-free %s
+// RUN: %env_scudo_opts=DeallocationTypeMismatch=1  not %run %t realloc     2>&1 | FileCheck --check-prefix=CHECK-realloc %s
+// RUN: %env_scudo_opts=DeallocationTypeMismatch=0      %run %t realloc     2>&1
 
 // Tests that the various aligned allocation functions work as intended. Also
 // tests for the condition where the alignment is not a power of 2.
 
 #include <assert.h>
 #include <errno.h>
 #include <malloc.h>
 #include <stdint.h>
for (int i = (sizeof(void *) == 4) ? 3 : 4; i < 19; i++) {
           assert(((uintptr_t)p & (alignment - 1)) == 0);
           free(p);
         }
       }
     }
     // For larger alignment, reduce the number of allocations to avoid running
     // out of potential addresses (on 32-bit).
     for (int i = 19; i <= 24; i++) {
+      alignment = 1U << i;
       for (int k = 0; k < 3; k++) {
         p = memalign(alignment, 0x1000 - (2 * sizeof(void *) * k));
         assert(p);
         assert(((uintptr_t)p & (alignment - 1)) == 0);
         free(p);
       }
     }
   }
if (!strcmp(argv[1], "invalid")) {
     err = posix_memalign(&p, 3, size);
     assert(p == p_unchanged);
     assert(err == EINVAL);
     // Alignment is a power of 2, but not a multiple of size(void *).
     err = posix_memalign(&p, 2, size);
     assert(p == p_unchanged);
     assert(err == EINVAL);
   }
+  if (!strcmp(argv[1], "double-free")) {
+    void *p = NULL;
+    posix_memalign(&p, 0x100, sizeof(int));
+    assert(p);
+    free(p);
+    free(p);
+  }
+  if (!strcmp(argv[1], "realloc")) {
+    // We cannot reallocate a memalign'd chunk.
+    void *p = memalign(16, 16);
+    assert(p);
+    p = realloc(p, 32);
+    free(p);
+  }
   return 0;
 }
+
+// CHECK-double-free: ERROR: invalid chunk state
+// CHECK-realloc: ERROR: allocation type mismatch when reallocating address

test/scudo/mismatch.cpp

 // RUN: %clangxx_scudo %s -o %t
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=1 not %run %t mallocdel       2>&1 | FileCheck --check-prefix=CHECK-dealloc %s
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=0     %run %t mallocdel       2>&1
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=1 not %run %t newfree         2>&1 | FileCheck --check-prefix=CHECK-dealloc %s
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=0     %run %t newfree         2>&1
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=1 not %run %t memaligndel     2>&1 | FileCheck --check-prefix=CHECK-dealloc %s
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=0     %run %t memaligndel     2>&1
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=1 not %run %t memalignrealloc 2>&1 | FileCheck --check-prefix=CHECK-realloc %s
-// RUN: %env_scudo_opts=DeallocationTypeMismatch=0     %run %t memalignrealloc 2>&1
+// RUN: %env_scudo_opts=DeallocationTypeMismatch=1 not %run %t mallocdel 2>&1 | FileCheck --check-prefix=CHECK-dealloc %s
+// RUN: %env_scudo_opts=DeallocationTypeMismatch=0     %run %t mallocdel 2>&1
+// RUN: %env_scudo_opts=DeallocationTypeMismatch=1 not %run %t newfree   2>&1 | FileCheck --check-prefix=CHECK-dealloc %s
+// RUN: %env_scudo_opts=DeallocationTypeMismatch=0     %run %t newfree   2>&1
 
 // Tests that type mismatches between allocation and deallocation functions are
 // caught when the related option is set.
 
 #include <assert.h>
-#include <malloc.h>
 #include <stdlib.h>
 #include <string.h>
 
 int main(int argc, char **argv)
 {
   assert(argc == 2);
   if (!strcmp(argv[1], "mallocdel")) {
     int *p = (int *)malloc(16);
     assert(p);
     delete p;
   }
   if (!strcmp(argv[1], "newfree")) {
     int *p = new int;
     assert(p);
     free((void *)p);
   }
-  if (!strcmp(argv[1], "memaligndel")) {
-    int *p = (int *)memalign(16, 16);
-    assert(p);
-    delete p;
-  }
-  if (!strcmp(argv[1], "memalignrealloc")) {
-    void *p = memalign(16, 16);
-    assert(p);
-    p = realloc(p, 32);
-    free(p);
-  }
   return 0;
 }
 
 // CHECK-dealloc: ERROR: allocation type mismatch when deallocating address
 // CHECK-realloc: ERROR: allocation type mismatch when reallocating address

test/scudo/realloc.cpp

 // RUN: %clangxx_scudo %s -lstdc++ -o %t
-// RUN: %run %t pointers 2>&1
-// RUN: %run %t contents 2>&1
+// RUN: %run %t pointers   2>&1
+// RUN: %run %t contents   2>&1
 // RUN: %run %t usablesize 2>&1
 
 // Tests that our reallocation function returns the same pointer when the
 // requested size can fit into the previously allocated chunk. Also tests that
 // a new chunk is returned if the size is greater, and that the contents of the
 // chunk are left unchanged. Finally, checks that realloc copies the usable
 // size of the old chunk to the new one (as opposed to the requested size).
 
 #include <assert.h>
 #include <malloc.h>
 #include <string.h>
 
 #include <vector>
 
+#include <sanitizer/allocator_interface.h>
+
 int main(int argc, char **argv)
 {
   void *p, *old_p;
   // Those sizes will exercise both allocators (Primary & Secondary).
   std::vector<size_t> sizes{1, 16, 1024, 32768, 1 << 16, 1 << 17, 1 << 20};
 
   assert(argc == 2);
 
   if (!strcmp(argv[1], "usablesize")) {
     // This tests a sketchy behavior inherited from poorly written libraries
     // that have become somewhat standard. When realloc'ing a chunk, the
     // copied contents should span the usable size of the chunk, not the
     // requested size.
     size_t size = 496, usable_size;
     p = nullptr;
     // Make sure we get a chunk with a usable size actually larger than size.
     do {
       if (p) free(p);
       size += 16;
       p = malloc(size);
-      usable_size = malloc_usable_size(p);
+      usable_size = __sanitizer_get_allocated_size(p);
       assert(usable_size >= size);
     } while (usable_size == size);
     for (int i = 0; i < usable_size; i++)
       reinterpret_cast<char *>(p)[i] = 'A';
     old_p = p;
     // Make sure we get a different chunk so that the data is actually copied.
     do {
       size *= 2;
       p = realloc(p, size);
       assert(p);
     } while (p == old_p);
     // The contents of the new chunk must match the old one up to usable_size.
     for (int i = 0; i < usable_size; i++)
       assert(reinterpret_cast<char *>(p)[i] == 'A');
     free(p);
   } else {
     for (size_t size : sizes) {
       if (!strcmp(argv[1], "pointers")) {
         old_p = p = realloc(nullptr, size);
         assert(p);
-        size = malloc_usable_size(p);
+        size = __sanitizer_get_allocated_size(p);
         // Our realloc implementation will return the same pointer if the size
         // requested is lower than or equal to the usable size of the associated
         // chunk.
         p = realloc(p, size - 1);
         assert(p == old_p);
         p = realloc(p, size);
         assert(p == old_p);
         // And a new one if the size is greater.

test/scudo/sizes.cpp

 #include <assert.h>
 #include <malloc.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <limits>
 #include <new>
 
+#include <sanitizer/allocator_interface.h>
+
 int main(int argc, char **argv) {
   assert(argc == 2);
-  const char *action = argv[1];
-  fprintf(stderr, "%s:\n", action);
 
 #if __LP64__ || defined(_WIN64)
   static const size_t kMaxAllowedMallocSize = 1ULL << 40;
   static const size_t kChunkHeaderSize = 16;
 #else
   static const size_t kMaxAllowedMallocSize = 2UL << 30;
   static const size_t kChunkHeaderSize = 8;
 #endif
 
-  if (!strcmp(action, "malloc")) {
+  if (!strcmp(argv[1], "malloc")) {
     void *p = malloc(kMaxAllowedMallocSize);
     assert(!p);
     p = malloc(kMaxAllowedMallocSize - kChunkHeaderSize);
     assert(!p);
-  } else if (!strcmp(action, "calloc")) {
+  } else if (!strcmp(argv[1], "calloc")) {
     // Trigger an overflow in calloc.
     size_t size = std::numeric_limits<size_t>::max();
     void *p = calloc((size / 0x1000) + 1, 0x1000);
     assert(!p);
-  } else if (!strcmp(action, "new")) {
+  } else if (!strcmp(argv[1], "new")) {
     void *p = operator new(kMaxAllowedMallocSize);
     assert(!p);
-  } else if (!strcmp(action, "new-nothrow")) {
+  } else if (!strcmp(argv[1], "new-nothrow")) {
     void *p = operator new(kMaxAllowedMallocSize, std::nothrow);
     assert(!p);
-  } else if (!strcmp(action, "usable")) {
+  } else if (!strcmp(argv[1], "usable")) {
     // Playing with the actual usable size of a chunk.
     void *p = malloc(1007);
     assert(p);
-    size_t size = malloc_usable_size(p);
+    size_t size = __sanitizer_get_allocated_size(p);
     assert(size >= 1007);
     memset(p, 'A', size);
     p = realloc(p, 2014);
     assert(p);
-    size = malloc_usable_size(p);
+    size = __sanitizer_get_allocated_size(p);
     assert(size >= 2014);
     memset(p, 'B', size);
     free(p);
   } else {
     assert(0);
   }
 
   return 0;
 }
 
 // CHECK: allocator is terminating the process