Use LLVM's DenseSet insteead of unordered_set.

[ruiu]

Summary

DenseSet is used throughout lld, so it is better for consistency.

[efriedma]

lld/wasm/SymbolTable.cpp

37 ↗

(On Diff #134106)

Don't you need a SetVector here?

[ruiu]

lld/wasm/SymbolTable.cpp

37 ↗

(On Diff #134106)

Forgive my ignorance, but what's the difference between DenseSet and SetVector?

[efriedma]

lld/wasm/SymbolTable.cpp

37 ↗

(On Diff #134106)

Iterating over a SetVector produces values in the order they were inserted; iterating over a DenseSet uses an arbitrary ordering. See http://llvm.org/docs/ProgrammersManual.html#llvm-adt-setvector-h .

[ruiu]

lld/wasm/SymbolTable.cpp

37 ↗

(On Diff #134106)

Ah, thanks. This code is to produce error messages, so the order of the output of this code doesn't have to be deterministic, but it is still nice if it's deterministic. I'll make a change to use SetVector.

[ruiu]

• use SetVector instead of DenseMap

lld/trunk/wasm/SymbolTable.cpp

 //===- SymbolTable.cpp ----------------------------------------------------===//
 //
 //                             The LLVM Linker
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "SymbolTable.h"
 
 #include "Config.h"
 #include "InputChunks.h"
 #include "WriterUtils.h"
 #include "lld/Common/ErrorHandler.h"
 #include "lld/Common/Memory.h"
-
-#include <unordered_set>
+#include "llvm/ADT/SetVector.h"
 
 #define DEBUG_TYPE "lld"
 
 using namespace llvm;
 using namespace llvm::wasm;
 using namespace lld;
 using namespace lld::wasm;
 
 SymbolTable *lld::wasm::Symtab;
 
 void SymbolTable::addFile(InputFile *File) {
   log("Processing: " + toString(File));
   File->parse();
 
   if (auto *F = dyn_cast<ObjFile>(File))
     ObjectFiles.push_back(F);
 }
 
 void SymbolTable::reportRemainingUndefines() {
-  std::unordered_set<Symbol *> Undefs;
+  SetVector<Symbol *> Undefs;
   for (Symbol *Sym : SymVector) {
     if (Sym->isUndefined() && !Sym->isWeak() &&
         Config->AllowUndefinedSymbols.count(Sym->getName()) == 0) {
       Undefs.insert(Sym);
     }
   }
 
   if (Undefs.empty())