This is an archive of the discontinued LLVM Phabricator instance.

[OMPT][test] Correct warning about added wrapper functions
ClosedPublic

Authored by Hahnfeld on Feb 12 2018, 6:56 AM.

Download Raw Diff

Details

Reviewers

protze.joachim
omalyshe
hbae

Commits

rGcc6d29d72cd5: [OMPT][test] Correct warning about added wrapper functions
rOMP325131: [OMPT][test] Correct warning about added wrapper functions
rL325131: [OMPT][test] Correct warning about added wrapper functions

Summary

This affects all outlined functions, not just tasks! Only show warning
when using Clang 5.0 or later.

Diff Detail

Repository: rL LLVM

Event Timeline

Hahnfeld created this revision.Feb 12 2018, 6:56 AM

Herald added a subscriber: openmp-commits. · View Herald TranscriptFeb 12 2018, 6:56 AM

LGTM.

This revision is now accepted and ready to land.Feb 14 2018, 1:44 AM

Closed by commit rL325131: [OMPT][test] Correct warning about added wrapper functions (authored by Hahnfeld). · Explain WhyFeb 14 2018, 7:17 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 14 2018, 7:17 AM

Revision Contents

Path

Size

openmp/

trunk/

runtime/

test/

ompt/

callback.h

6 lines

Diff 134225

openmp/trunk/runtime/test/ompt/callback.h

	Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
	// clang (version 5.0 and above) adds an intermediate function call with debug flag (-g)			// clang (version 5.0 and above) adds an intermediate function call with debug flag (-g)
	#if defined(TEST_NEED_PRINT_FRAME_FROM_OUTLINED_FN)			#if defined(TEST_NEED_PRINT_FRAME_FROM_OUTLINED_FN)
	#if defined(DEBUG) && defined(__clang__) && __clang_major__ >= 5			#if defined(DEBUG) && defined(__clang__) && __clang_major__ >= 5
	#define print_frame_from_outlined_fn(level) print_frame(level+1)			#define print_frame_from_outlined_fn(level) print_frame(level+1)
	#else			#else
	#define print_frame_from_outlined_fn(level) print_frame(level)			#define print_frame_from_outlined_fn(level) print_frame(level)
	#endif			#endif

	#warning "Clang 5.0 and later add an additional wrapper function for tasks when compiling with debug information."			#if defined(__clang__) && __clang_major__ >= 5
	#warning "Please define -DDEBUG iff you manually pass in -g!"			#warning "Clang 5.0 and later add an additional wrapper for outlined functions when compiling with debug information."
				#warning "Please define -DDEBUG iff you manually pass in -g to make the tests succeed!"
				#endif
	#endif			#endif

	// This macro helps to define a label at the current position that can be used			// This macro helps to define a label at the current position that can be used
	// to get the current address in the code.			// to get the current address in the code.
	//			//
	// For print_current_address():			// For print_current_address():
	// To reliably determine the offset between the address of the label and the			// To reliably determine the offset between the address of the label and the
	// actual return address, we insert a NOP instruction as a jump target as the			// actual return address, we insert a NOP instruction as a jump target as the
	▲ Show 20 Lines • Show All 650 Lines • Show Last 20 Lines